update pr template to not show warning in pr#7428
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7428 +/- ##
=======================================
Coverage 80.40% 80.40%
=======================================
Files 732 732
Lines 31050 31050
=======================================
Hits 24965 24965
Misses 6085 6085 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overall package sizeSelf size: 4.56 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 813.08 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
This was deliberate, so hopefully the people posting PRs look at the description and HAVE TO remove that line manually, so they can't say they didn't see it hahaha. But I understand that you want to remove it |
BridgeAR
dismissed
their stale review
After giving it another though, I agree with @simon-id
That's why I wrapped it in a lot of exclamation marks, and we could potentially make it even more obvious. I just don't like that basically all PRs will have that at the top from now on otherwise. |
|
@simon-id Maybe we could make it a checkbox? That would make more sense as it would show the actual state and would require an interaction to confirm tests exist. A message can be ignored, a checkbox that needs to be checked cannot. |
|
@rochdev I like it the way it is now because it's such a "ah you didn't read the PR template and you left the disclaimer, gotcha!". |
I didn't expect the change to be contentious, so I don't mind closing the PR and leaving it as-is either. I thought it might have been accidental. |
|
No no I mean it, not being passive aggresive hahaha, I honestly don't mind this change, if others approve, that's fine by me |
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
I guess this would stay open long if there is no decision. I will approve
4 participants
Please make sure your changes are properly tested!
What does this PR do?
Update PR template to not show warning in PR.
Motivation
Right now the warning is shown in the PR description visible publicly. It should only warn the author of the PR, it doesn't make sense to have it in the description.
Additional Notes