Skip to content

Add pubsub.subscription to GCP pubsub pull subsciptions #7446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BridgeAR merged 11 commits into from
Feb 10, 2026
+9 −6
Merged

Add pubsub.subscription to GCP pubsub pull subsciptions #7446

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2fa81c2
Add pubsub.subscription to pull subsciptions
nina9753 Feb 5, 2026
de4da29
update to name
nina9753 Feb 5, 2026
032d038
Merge branch 'master' into nina.rei/fix/add_gcp_pubsub_subscription
nina9753 Feb 5, 2026
822b87f
update the tests
nina9753 Feb 6, 2026
46522ee
Merge branch 'master' into nina.rei/fix/add_gcp_pubsub_subscription
nina9753 Feb 6, 2026
7dfe665
update tests
nina9753 Feb 6, 2026
20253b0
Update packages/datadog-plugin-google-cloud-pubsub/test/index.spec.js
nina9753 Feb 6, 2026
58b0b3d
Update packages/datadog-plugin-google-cloud-pubsub/test/index.spec.js
nina9753 Feb 6, 2026
085eaf6
Merge branch 'master' into nina.rei/fix/add_gcp_pubsub_subscription
nina9753 Feb 6, 2026
cbbabfd
simplify the tests
nina9753 Feb 10, 2026
67d302b
Merge branch 'master' into nina.rei/fix/add_gcp_pubsub_subscription
nina9753 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/datadog-plugin-google-cloud-pubsub/src/consumer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,10 @@ class GoogleCloudPubsubConsumerPlugin extends ConsumerPlugin {
const meta = {
'gcloud.project_id': subscription.pubsub.projectId,
'pubsub.topic': topic,
'pubsub.message_id': message.messageId,
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use pull message id field instead of messageId

For pull subscriptions, the Pub/Sub Message object exposes the server-assigned ID as message.id (this was what the code used before). Switching the tag to message.messageId means the tag will be undefined for standard pull messages, so pubsub.message_id stops being recorded and downstream correlation/debugging based on message ID is lost. This regression only affects pull subscriptions where the Message instance does not include a messageId alias.

Useful? React with 👍 / 👎.

'span.kind': 'consumer',
'pubsub.subscription': subscription.name,
'pubsub.subscription_type': 'pull',
'pubsub.span_type': 'message_processing',
'messaging.operation': 'receive',
base_service: baseService,
service_override_type: 'custom',
Expand Down Expand Up @@ -171,9 +172,6 @@ class GoogleCloudPubsubConsumerPlugin extends ConsumerPlugin {
metrics,
}, ctx)

if (message.id) {
span.setTag('pubsub.message_id', message.id)
}
if (message.publishTime) {
span.setTag('pubsub.publish_time', message.publishTime.toISOString())
}
Expand Down
Loading