Collect framework endpoints by estringana · Pull Request #3548 · DataDog/dd-trace-php

estringana · 2025-12-24T11:47:21Z

Description

This feature will collect(once) all endpoints of the following framework: symfony(except version 4), laravel and wordpress

Reviewer checklist

Test coverage seems ok.
Appropriate labels assigned.

codecov-commenter · 2025-12-30T16:43:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.11%. Comparing base (21d2f00) to head (fdf47cf).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3548      +/-   ##
==========================================
- Coverage   62.24%   62.11%   -0.14%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
- Hits         8333     8315      -18     
- Misses       4257     4273      +16     
- Partials      797      799       +2

see 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d2f00...fdf47cf. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2025-12-30T17:43:00Z

Benchmarks [ tracer ]

Benchmark execution time: 2026-02-04 16:05:38

Comparing candidate commit ffeafcb in PR branch estringana/collect-framework-endpoints-2 with baseline commit 21d2f00 in branch master.

Found 0 performance improvements and 9 performance regressions! Performance is the same for 181 metrics, 4 unstable metrics.

scenario:PDOBench/benchPDOOverhead

🟥 execution_time [+5.927µs; +10.694µs] or [+2.711%; +4.891%]

scenario:PDOBench/benchPDOOverheadWithDBM

🟥 execution_time [+7.544µs; +11.329µs] or [+3.480%; +5.225%]

scenario:PHPRedisBench/benchRedisOverhead

🟥 execution_time [+35.509µs; +47.549µs] or [+4.239%; +5.677%]

scenario:SymfonyBench/benchSymfonyOverhead

🟥 execution_time [+259.490µs; +376.410µs] or [+3.256%; +4.723%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

🟥 execution_time [+277.599µs; +381.321µs] or [+3.469%; +4.765%]

scenario:WordPressBench/benchWordPressDdprof

🟥 execution_time [+2.086ms; +2.240ms] or [+7.120%; +7.646%]

scenario:WordPressBench/benchWordPressDdprof-opcache

🟥 execution_time [+2.033ms; +2.185ms] or [+6.934%; +7.451%]

scenario:WordPressBench/benchWordPressOverhead

🟥 execution_time [+2.112ms; +2.327ms] or [+7.750%; +8.540%]

scenario:WordPressBench/benchWordPressOverhead-opcache

🟥 execution_time [+2.104ms; +2.405ms] or [+7.687%; +8.787%]

cataphract · 2026-01-12T19:51:04Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f84f03e8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-12T19:57:16Z

components-rs/telemetry.rs

+) -> bool {
+    let cache_entry = ddog_sidecar_telemetry_cache_get_or_update(cache, service, env);
+    let result = cache_entry.last_endpoints_push.elapsed().map_or(false, |d| d < Duration::from_secs(60)); // 1 minute


Keep endpoint collection from expiring after 60s

This predicate only treats endpoints as “collected” for 60 seconds (elapsed() < 60s), so in long‑running PHP workers the Symfony/Laravel/WordPress hooks will start re‑enumerating routes/posts and re‑emitting app‑endpoints after a minute. That contradicts the “collect once” behavior and can create duplicate telemetry plus repeated route/DB scans on every request once the minute elapses.

Useful? React with 👍 / 👎.

appsec/tests/integration/src/main/groovy/com/datadog/appsec/php/TelemetryHelpers.groovy

datadog-datadog-prod-us1 · 2026-01-13T09:53:30Z

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

Endpoints are sent() from com.datadog.appsec.php.integration.Laravel8xTests (Datadog) (Fix with Cursor)
Assertion failed: 

assert endpoints.size() == 6
       |         |      |
       |         1      false
       [com.datadog.appsec.php.TelemetryHelpers$Endpoint@2f0cab82]

Assertion failed: 

assert endpoints.size() == 6
...
Endpoints are sent() from com.datadog.appsec.php.integration.Symfony62Tests (Datadog) (Fix with Cursor)
Assertion failed: 

assert endpoints.size() == 6
       |         |      |
       |         1      false
       [com.datadog.appsec.php.TelemetryHelpers$Endpoint@3359c3f6]

Assertion failed: 

assert endpoints.size() == 6
...

🧪 1024 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 698377c3000000002b9c3de84f3c5b79
tid: 698377c300000000
hexProcessTraceId: 2b9c3de84f3c5b79
hexProcessSpanId: 753b95d000eb0a5d
processTraceId: 3142454707968826233
processSpanId: 8447510246664637021
View all

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: fdf47cf | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

github-actions · 2026-01-27T08:51:12Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

If you need to update snapshots, please refer to CONTRIBUTING.md

1 occurrences of :

- "error.message": "Thrown Symfony\\Component\\Routing\\Exception\\ResourceNotFoundException in {path}/tests/Frameworks/Symfony/Version_2_3/app/cache/prod/appProdUrlMatcher.php:60"
+ "error.message": "Thrown Symfony\\Component\\Routing\\Exception\\ResourceNotFoundException in {path}/tests/Frameworks/Symfony/Version_2_3/app/cache/prod/appProdUrlMatcher.php:65"

1 occurrences of :

- "error.message": "Thrown Symfony\\Component\\Routing\\Exception\\ResourceNotFoundException in {path}/tests/Frameworks/Symfony/Version_2_8/app/cache/prod/appProdProjectContainerUrlMatcher.php:62"
+ "error.message": "Thrown Symfony\\Component\\Routing\\Exception\\ResourceNotFoundException in {path}/tests/Frameworks/Symfony/Version_2_8/app/cache/prod/appProdProjectContainerUrlMatcher.php:67"

components-rs/common.h

...c/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/Laravel8xTests.groovy

...c/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/Symfony62Tests.groovy

ext/ddtrace.c

juice928 · 2026-01-28T11:42:02Z

👋 Hi, I'm an automated AI code review bot. I ran some checks on this PR and found 3 points that might be worth attention (could be false positives, please use your judgment):

Synchronous route iteration in Laravel integration
- Location: src/DDTrace/Integrations/Laravel/LaravelIntegration.php:L146-L155
- Impact: Synchronous FFI calls during the request path may cause latency spikes and thundering herd issues in large applications.
- Suggestion: Consider moving endpoint collection to a background process or performing it asynchronously to optimize the request path.
Synchronous route collection in Symfony integration
- Location: src/DDTrace/Integrations/Symfony/SymfonyIntegration.php:L592-L611
- Impact: Iterating over the entire RouteCollection synchronously might lead to performance overhead and resource contention when the cache expires.
- Suggestion: It might be more efficient to handle this telemetry collection through an asynchronous mechanism.
Extensive database query in WordPress integration
- Location: src/DDTrace/Integrations/WordPress/WordPressIntegration.php:L38-L54
- Impact: Fetching all posts at once via posts_per_page => -1 could lead to memory exhaustion or timeouts on sites with large datasets.
- Suggestion: Consider using pagination, limiting the query scope, or selecting only essential fields to ensure system stability.

If you find these suggestions disruptive, you can reply "stop" , and I'll automatically skip this repository in the future.

cataphract · 2026-01-28T14:50:43Z

if the alpine thing continues to fail and you can't configure the rust getrandom crate not to use the symbol, you can try to provide the symbol as done here: https://github.com/DataDog/nginx-datadog/blob/master/build_env/glibc_compat.c#L200-L227

estringana · 2026-02-04T16:29:36Z

ext/compat_getrandom.c

+// Provide a weak, local fallback so that:
+// - On older libcs without getrandom, we satisfy the symbol at runtime.
+// - On newer libcs, libc's strong symbol may be preferred by the runtime loader.
+__attribute__((weak)) ssize_t getrandom(void *buf, size_t buflen, unsigned int flags) {


@bwoebi would you mind to have a look at this? I had to add it because the version of libdatadog used by this brach was calling getrandom and in some old alpine version it was not present

estringana force-pushed the estringana/collect-framework-endpoints-2 branch from be10f87 to 4dd7002 Compare January 2, 2026 11:38

estringana changed the title ~~Estringana/collect framework endpoints 2~~ Collect framework endpoints Jan 8, 2026

estringana requested a review from cataphract January 8, 2026 09:18

estringana marked this pull request as ready for review January 8, 2026 11:30

estringana requested review from a team as code owners January 8, 2026 11:30

chatgpt-codex-connector bot reviewed Jan 12, 2026

View reviewed changes

estringana force-pushed the estringana/collect-framework-endpoints-2 branch from 7f84f03 to 4bdf65f Compare January 13, 2026 09:46

estringana force-pushed the estringana/collect-framework-endpoints-2 branch 3 times, most recently from 675114b to c5a5e84 Compare January 26, 2026 14:27

estringana force-pushed the estringana/collect-framework-endpoints-2 branch from 8bdf101 to 78b097a Compare January 27, 2026 09:11

cataphract reviewed Jan 27, 2026

View reviewed changes

estringana force-pushed the estringana/collect-framework-endpoints-2 branch 3 times, most recently from 64d9505 to 7a511a5 Compare January 28, 2026 11:10

estringana force-pushed the estringana/collect-framework-endpoints-2 branch from 849a92d to b1c51ed Compare January 28, 2026 15:13

cataphract approved these changes Jan 28, 2026

View reviewed changes

estringana force-pushed the estringana/collect-framework-endpoints-2 branch 2 times, most recently from 1571560 to 0c21a75 Compare January 28, 2026 17:03

Collect framework endpoints

9164b2a

estringana force-pushed the estringana/collect-framework-endpoints-2 branch from 0c21a75 to 9164b2a Compare January 28, 2026 17:09

estringana added 14 commits January 29, 2026 10:56

Fix getrandom

de88472

Fix telemetry tests

a7817d4

Add test to ensure endpoint are collected just once

91ac3fb

Extend warmup on symfony

91d3a48

Revert warm up

99b05d2

Avoid sending symfony endpoints

a39fb9f

Debug piece by piece symfony

673dd83

Test adding one endpoint

2133c82

One step more

5b3e456

Debug symfony benchmarks

0be71a1

Debug

420e2c5

Change approach to collect routes on symfony

7e5600c

Fix symfomy url generation

e31803d

Add debug logs when endpoitns are added

ffeafcb

estringana commented Feb 4, 2026

View reviewed changes

Remove debbung lines

fdf47cf

Conversation

estringana commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Reviewer checklist

Uh oh!

codecov-commenter commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [ tracer ]

scenario:PDOBench/benchPDOOverhead

scenario:PDOBench/benchPDOOverheadWithDBM

scenario:PHPRedisBench/benchRedisOverhead

scenario:SymfonyBench/benchSymfonyOverhead

scenario:SymfonyBench/benchSymfonyOverhead-opcache

scenario:WordPressBench/benchWordPressDdprof

scenario:WordPressBench/benchWordPressDdprof-opcache

scenario:WordPressBench/benchWordPressOverhead

scenario:WordPressBench/benchWordPressOverhead-opcache

Uh oh!

cataphract commented Jan 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

datadog-datadog-prod-us1 bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

Uh oh!

github-actions bot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Snapshots difference summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juice928 commented Jan 28, 2026

Uh oh!

cataphract commented Jan 28, 2026

Uh oh!

estringana Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

estringana commented Dec 24, 2025 •

edited

Loading

codecov-commenter commented Dec 30, 2025 •

edited

Loading

pr-commenter bot commented Dec 30, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Jan 13, 2026 •

edited

Loading

github-actions bot commented Jan 27, 2026 •

edited

Loading