Skip to content

Conversation

@ltfschoen
Copy link
Contributor

@ltfschoen ltfschoen commented Mar 17, 2022

Trying to fix benchmarking error since a solution was mentioned here, but we already applied those changes to our codebase here and we are already using 'polkadot_v0.9.17', and Cumulus 'polkadot_v0.9.17' already includes the change that they said should fix it in their upstream here https://github.com/paritytech/cumulus/commits/polkadot-v0.9.17, but it still doesn't work

When I run cargo check -p datahighway-collator --features runtime-benchmarks in this PR, it generates error shown below, although this time it is complaining about pallet-xcm rather than pallet-society

  error[E0046]: not all trait items implemented, missing: `successful_origin`
      --> /Users/ls2/.cargo/git/checkouts/polkadot-4038f27d5e4ea2e8/de0ecd4/xcm/pallet-xcm/src/lib.rs:1508:1
       |
  1508 | / impl<O: OriginTrait + From<Origin>, F: Contains<MultiLocation>> EnsureOrigin<O> for EnsureXcm<F>
  1509 | | where
  1510 | |     O::PalletsOrigin: From<Origin> + TryInto<Origin, Error = O::PalletsOrigin>,
  1511 | | {
  ...    |
  1527 | |     }
  1528 | | }
       | |_^ missing `successful_origin` in implementation
       |
       = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }`

  error[E0046]: not all trait items implemented, missing: `successful_origin`
      --> /Users/ls2/.cargo/git/checkouts/polkadot-4038f27d5e4ea2e8/de0ecd4/xcm/pallet-xcm/src/lib.rs:1533:1
       |
  1533 | / impl<O: OriginTrait + From<Origin>, F: Contains<MultiLocation>> EnsureOrigin<O>
  1534 | |     for EnsureResponse<F>
  1535 | | where
  1536 | |     O::PalletsOrigin: From<Origin> + TryInto<Origin, Error = O::PalletsOrigin>,
  ...    |
  1552 | |     }
  1553 | | }
       | |_^ missing `successful_origin` in implementation
       |
       = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant