Add periodicity to UNet using CircularPad2d#55
Draft
ma595 wants to merge 15 commits intoupdates-for-high-resolutionfrom
Draft
Add periodicity to UNet using CircularPad2d#55ma595 wants to merge 15 commits intoupdates-for-high-resolutionfrom
CircularPad2d#55ma595 wants to merge 15 commits intoupdates-for-high-resolutionfrom
Conversation
padding=0 condition never met in Conv_block, Attention_block or Upsample.
Collaborator
|
Thanks for raising this @ma595 . Would be good to see if we can make the output continuous across the 0 meridian line. |
Contributor
|
@ma595 Looks like a nice strainghtforward fix. Is it possible to add this during inference itself? Or do we need to retain the model with the ReplicationPad2d layer? |
Collaborator
Author
I think we'd need to retrain the model. |
TomMelt
reviewed
Dec 9, 2025
| kernel_size=kernel_size, | ||
| stride=stride, | ||
| padding=padding, | ||
| padding=0, |
Collaborator
There was a problem hiding this comment.
just a reminder, can you remove these lines completely. The default for Conv2d is padding=0. https://docs.pytorch.org/docs/stable/generated/torch.nn.Conv2d.html
b4eeffb to
45ac007
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to address the issue observed by @TomMelt, where a vertical 'seam' or fold is observed at the meridian line (lon = 0). We hadn't noticed this before as we were plotting data (lons 0-360).
This is illustrated here in the raw flux outputs of the network. Tom has already verified that the inputs are smooth.

This issue appears because the Unet does not enforce longitudinal periodicity. We can fix this by using the
CircularPad2dfunction where convolution is done, i.e. in classesConv_block,UpsampleandAttention_block.I also recommend a replication pad at the poles using nn.ReplicationPad2d. This will eliminate potential steep gradients there.
TODO:
Closes #56