perf: Replace internal List for static series

.editorconfig

@@ -137,6 +137,8 @@ dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion
 # Diagnostic analyzer suppressions
 dotnet_diagnostic.IDE0058.severity = none        # Unused expression value, use _ discard variable
 dotnet_diagnostic.IDE0230.severity = suggestion  # Use raw string literal when beneficial
+dotnet_diagnostic.IDE0305.severity = none        # Use collection expression for fluent, foo.ToList→[..foo]
+dotnet_diagnostic.IDE0306.severity = none        # Use collection expression for new, new(foo)→[..foo]
 
 # remove this when no-longer supporting pre-9.0 frameworks
 dotnet_diagnostic.IDE0330.severity = none        # Prefer 'System.Threading.Lock'

src/a-d/Adl/Adl.StaticSeries.cs

@@ -17,7 +17,7 @@ public static IReadOnlyList<AdlResult> ToAdl(this IReadOnlyList<IQuote> source)
 
         // initialize
         int length = source.Count;
-        List<AdlResult> results = new(length);
+        AdlResult[] results = new AdlResult[length];
 
         // roll through source values
         for (int i = 0; i < length; i++)
@@ -30,9 +30,9 @@ public static IReadOnlyList<AdlResult> ToAdl(this IReadOnlyList<IQuote> source)
                 source[i].Volume,
                 i > 0 ? results[i - 1].Adl : 0);
 
-            results.Add(r);
+            results[i] = r;
         }
 
-        return results;
+        return new List<AdlResult>(results);
     }
 }

src/a-d/Adx/Adx.StaticSeries.cs

@@ -33,7 +33,7 @@ private static List<AdxResult> CalcAdx(
 
         // initialize
         int length = quotes.Count;
-        List<AdxResult> results = new(length);
+        AdxResult[] results = new AdxResult[length];
 
         double prevHigh = 0;
         double prevLow = 0;
@@ -60,7 +60,7 @@ private static List<AdxResult> CalcAdx(
                 prevLow = q.Low;
                 prevClose = q.Close;
 
-                results.Add(new(Timestamp: q.Timestamp));
+                results[i] = new(Timestamp: q.Timestamp);
                 continue;
             }
 
@@ -89,7 +89,7 @@ private static List<AdxResult> CalcAdx(
             // skip DM initialization period
             if (i < lookbackPeriods)
             {
-                results.Add(new(Timestamp: q.Timestamp));
+                results[i] = new(Timestamp: q.Timestamp);
                 continue;
             }
 
@@ -118,7 +118,7 @@ private static List<AdxResult> CalcAdx(
 
             if (trs == 0)
             {
-                results.Add(new(Timestamp: q.Timestamp));
+                results[i] = new(Timestamp: q.Timestamp);
                 continue;
             }
 
@@ -177,9 +177,9 @@ private static List<AdxResult> CalcAdx(
                 Adx: adx.NaN2Null(),
                 Adxr: adxr.NaN2Null());
 
-            results.Add(r);
+            results[i] = r;
         }
 
-        return results;
+        return new List<AdxResult>(results);
     }
 }

src/a-d/Alligator/Alligator.StaticSeries.cs

@@ -43,7 +43,7 @@ IReadOnlyList<IReusable> values
 
         // initialize
         int length = values.Count;
-        List<AlligatorResult> results = new(length);
+        AlligatorResult[] results = new AlligatorResult[length];
 
         // roll through source values
         for (int i = 0; i < length; i++)
@@ -125,13 +125,13 @@ IReadOnlyList<IReusable> values
             }
 
             // result
-            results.Add(new AlligatorResult(
+            results[i] = new AlligatorResult(
                 values[i].Timestamp,
                 jaw.NaN2Null(),
                 teeth.NaN2Null(),
-                lips.NaN2Null()));
+                lips.NaN2Null());
         }
 
-        return results;
+        return new List<AlligatorResult>(results);
     }
 }

src/a-d/Alma/Alma.StaticSeries.cs

@@ -26,7 +26,7 @@ public static IReadOnlyList<AlmaResult> ToAlma(
 
         // initialize
         int length = source.Count;
-        List<AlmaResult> results = new(length);
+        AlmaResult[] results = new AlmaResult[length];
 
         // determine price weight constants
         double m = offset * (lookbackPeriods - 1);
@@ -62,11 +62,11 @@ public static IReadOnlyList<AlmaResult> ToAlma(
                 alma = weightedSum / norm;
             }
 
-            results.Add(
-            new(Timestamp: source[i].Timestamp,
-                Alma: alma.NaN2Null()));
+            results[i] = new(
+                Timestamp: source[i].Timestamp,
+                Alma: alma.NaN2Null());
         }
 
-        return results;
+        return new List<AlmaResult>(results);
     }
 }

src/a-d/Aroon/Aroon.StaticSeries.cs

@@ -33,7 +33,7 @@ private static List<AroonResult> CalcAroon(
 
         // initialize
         int length = quotes.Count;
-        List<AroonResult> results = new(length);
+        AroonResult[] results = new AroonResult[length];
 
         // roll through source values
         for (int i = 0; i < length; i++)
@@ -77,10 +77,10 @@ private static List<AroonResult> CalcAroon(
                 AroonDown: aroonDown,
                 Oscillator: aroonUp - aroonDown);
 
-            results.Add(r);
+            results[i] = r;
 
         }
 
-        return results;
+        return new List<AroonResult>(results);
     }
 }

src/a-d/Atr/Atr.StaticSeries.cs

@@ -34,7 +34,7 @@ internal static List<AtrResult> CalcAtr(
 
         // initialize
         int length = quotes.Count;
-        List<AtrResult> results = new(length);
+        AtrResult[] results = new AtrResult[length];
         double prevAtr = double.NaN;
         double prevClose = double.NaN;
         double sumTr = 0;
@@ -43,7 +43,7 @@ internal static List<AtrResult> CalcAtr(
         if (length > 0)
         {
             QuoteD q = quotes[0];
-            results.Add(new(Timestamp: q.Timestamp));
+            results[0] = new AtrResult(Timestamp: q.Timestamp);
             prevClose = q.Close;
         }
 
@@ -87,17 +87,15 @@ internal static List<AtrResult> CalcAtr(
                 atrp = null;
             }
 
-            AtrResult r = new(
+            results[i] = new AtrResult(
                 Timestamp: q.Timestamp,
                 Tr: tr.NaN2Null(),
                 Atr: atr.NaN2Null(),
                 Atrp: atrp);
 
-            results.Add(r);
-
             prevClose = q.Close;
         }
 
-        return results;
+        return new List<AtrResult>(results);
     }
 }

src/a-d/AtrStop/AtrStop.StaticSeries.cs

@@ -33,7 +33,7 @@ private static List<AtrStopResult> CalcAtrStop(
 
         // initialize
         int length = quotes.Count;
-        List<AtrStopResult> results = new(length);
+        AtrStopResult[] results = new AtrStopResult[length];
         List<AtrResult> atrResults = quotes.CalcAtr(lookbackPeriods);
 
         // prevailing direction and bands
@@ -47,7 +47,7 @@ private static List<AtrStopResult> CalcAtrStop(
             // handle warmup periods
             if (i < lookbackPeriods)
             {
-                results.Add(new(Timestamp: quotes[i].Timestamp));
+                results[i] = new(Timestamp: quotes[i].Timestamp);
                 continue;
             }
 
@@ -123,9 +123,9 @@ private static List<AtrStopResult> CalcAtrStop(
                     Atr: atr);
             }
 
-            results.Add(r);
+            results[i] = r;
         }
 
-        return results;
+        return new List<AtrStopResult>(results);
     }
 }

src/a-d/Awesome/Awesome.StaticSeries.cs

@@ -26,7 +26,7 @@ IReadOnlyList<IReusable> values
 
         // initialize
         int length = values.Count;
-        List<AwesomeResult> results = new(length);
+        AwesomeResult[] results = new AwesomeResult[length];
         double[] pr = new double[length];
 
         // roll through source values
@@ -57,14 +57,12 @@ IReadOnlyList<IReusable> values
                 normalized = pr[i] != 0 ? 100 * oscillator / pr[i] : null;
             }
 
-            AwesomeResult r = new(
+            results[i] = new AwesomeResult(
                 Timestamp: s.Timestamp,
                 Oscillator: oscillator,
                 Normalized: normalized);
-
-            results.Add(r);
         }
 
-        return results;
+        return new List<AwesomeResult>(results);
     }
 }

src/a-d/Beta/Beta.StaticSeries.cs

@@ -28,7 +28,7 @@ public static IReadOnlyList<BetaResult> ToBeta(
 
         // initialize
         int length = sourceEval.Count;
-        List<BetaResult> results = new(length);
+        BetaResult[] results = new BetaResult[length];
 
         bool calcSd = type is BetaType.All or BetaType.Standard;
         bool calcUp = type is BetaType.All or BetaType.Up;
@@ -68,10 +68,10 @@ public static IReadOnlyList<BetaResult> ToBeta(
             // skip warmup periods
             if (i < lookbackPeriods)
             {
-                results.Add(new(
+                results[i] = new(
                     Timestamp: eval.Timestamp,
                     ReturnsEval: evalReturns[i],
-                    ReturnsMrkt: mrktReturns[i]));
+                    ReturnsMrkt: mrktReturns[i]);
 
                 continue;
             }
@@ -108,18 +108,18 @@ public static IReadOnlyList<BetaResult> ToBeta(
                 convexity = (betaUp - betaDown) * (betaUp - betaDown);
             }
 
-            results.Add(
-            new(Timestamp: eval.Timestamp,
+            results[i] = new(
+                Timestamp: eval.Timestamp,
                 Beta: beta,
                 BetaUp: betaUp,
                 BetaDown: betaDown,
                 Ratio: ratio,
                 Convexity: convexity,
                 ReturnsEval: evalReturns[i],
-                ReturnsMrkt: mrktReturns[i]));
+                ReturnsMrkt: mrktReturns[i]);
         }
 
-        return results;
+        return new List<BetaResult>(results);
     }
 
     /// <summary>

src/a-d/BollingerBands/BollingerBands.StaticSeries.cs

@@ -24,7 +24,7 @@ public static IReadOnlyList<BollingerBandsResult> ToBollingerBands(
 
         // initialize
         int length = source.Count;
-        List<BollingerBandsResult> results = new(length);
+        BollingerBandsResult[] results = new BollingerBandsResult[length];
 
         // roll through source values
         for (int i = 0; i < length; i++)
@@ -51,7 +51,7 @@ public static IReadOnlyList<BollingerBandsResult> ToBollingerBands(
                 double? upperBand = sma + (standardDeviations * stdDev);
                 double? lowerBand = sma - (standardDeviations * stdDev);
 
-                results.Add(new BollingerBandsResult(
+                results[i] = new BollingerBandsResult(
 
                     Timestamp: s.Timestamp,
 
@@ -64,16 +64,16 @@ public static IReadOnlyList<BollingerBandsResult> ToBollingerBands(
 
                     ZScore: stdDev == 0 ? null : (s.Value - sma) / stdDev,
                     Width: sma == 0 ? null : (upperBand - lowerBand) / sma
-                ));
+                );
             }
 
             // initization period
             else
             {
-                results.Add(new(s.Timestamp));
+                results[i] = new(s.Timestamp);
             }
         }
 
-        return results;
+        return new List<BollingerBandsResult>(results);
     }
 }

src/a-d/Bop/Bop.StaticSeries.cs

@@ -33,7 +33,7 @@ private static List<BopResult> CalcBop(
 
         // initialize
         int length = quotes.Count;
-        List<BopResult> results = new(length);
+        BopResult[] results = new BopResult[length];
 
         double[] raw = quotes
             .Select(static x => x.High - x.Low != 0 ?
@@ -56,11 +56,11 @@ private static List<BopResult> CalcBop(
                 bop = sum / smoothPeriods;
             }
 
-            results.Add(new(
+            results[i] = new BopResult(
                 Timestamp: quotes[i].Timestamp,
-                Bop: bop.NaN2Null()));
+                Bop: bop.NaN2Null());
         }
 
-        return results;
+        return new List<BopResult>(results);
     }
 }

src/a-d/Cci/Cci.StaticSeries.cs

@@ -33,7 +33,7 @@ private static List<CciResult> CalcCci(
 
         // initialize
         int length = quotes.Count;
-        List<CciResult> results = new(length);
+        CciResult[] results = new CciResult[length];
         double[] tp = new double[length];
 
         // roll through source values
@@ -68,11 +68,11 @@ private static List<CciResult> CalcCci(
                     : ((tp[i] - avgTp) / (0.015 * avgDv)).NaN2Null();
             }
 
-            results.Add(new(
+            results[i] = new(
                 Timestamp: q.Timestamp,
-                Cci: cci));
+                Cci: cci);
         }
 
-        return results;
+        return new List<CciResult>(results);
     }
 }