Open
Conversation
andreiursudev
requested changes
Apr 4, 2024
| package org.example; | ||
| public class C01_10_MultiplicationOfIntegers { | ||
| public static int multiply(int num1, int num2) { | ||
| public static int multiplication(int num1, int num2) { |
Collaborator
There was a problem hiding this comment.
Methods usualy represent actions so multiply is correct, multiplication is not.
Collaborator
|
This PR has conflicts. Click the Resolve conflicts button and solve the conflicts. |
andreiursudev
requested changes
Apr 8, 2024
| void getNumber() { | ||
| String text= "1234"; | ||
| int number = P21_StringIntoInteger.stringToInteger(text); | ||
| assertEquals("1234", text); |
Collaborator
There was a problem hiding this comment.
Assert number variable not text.
andreiursudev
requested changes
Apr 11, 2024
| int number = P21_StringIntoInteger.stringToInteger(text); | ||
| assertEquals("1234", text); | ||
| String number = "1234"; | ||
| int text = P21_StringIntoInteger.stringToInteger(number); |
Collaborator
There was a problem hiding this comment.
Naming text an integer number is not good naming. Give variables proper names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will test the program where we convert a string into an integer