Skip to content

Conversation

@T0xicPotato
Copy link
Contributor

@T0xicPotato T0xicPotato commented Feb 4, 2026

fix: use USDC_CIRCLE instead of USDC for LP pools and margin accounts

Summary by CodeRabbit

  • Refactor
    • Restructured internal token and pool configurations to improve system organization. Updated mappings to support both legacy and current asset configurations.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

The PR restructures pool mappings in the Sharwa Finance adapter by introducing a legacy_pools object, separating legacy and new pool configurations (USDC, WETH, WBTC), and replacing the single marginAccount with both legacy_margin_account and margin_account entries. TVL token-owner pairs are updated to reference the new structure.

Changes

Cohort / File(s) Summary
Pool and Margin Account Mappings
projects/sharwa-finance/index.js
Introduced legacy_pools and pool mappings structure; replaced marginAccount with legacy_margin_account and margin_account; updated TVL token-owner pairs to use the new configuration with appropriate legacy and margin account references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • g1nt0ki

Poem

🐰 Pools are mapped and margins dance,
Legacy and new in fine romance,
Token pairs shuffle, find their place,
A refactored garden, the swiftest pace,
Sharwa's adapted with style and grace! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description is identical to the title and lacks substantive detail about the change, motivation, or impact despite the template requiring new protocol listing information. Provide a detailed description explaining why USDC_CIRCLE is being used instead of USDC, what problem this fixes, and any relevant context about the Sharwa Finance adapter being updated.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: replacing USDC with USDC_CIRCLE for LP pools and margin accounts.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@llamabutler
Copy link

The adapter at projects/sharwa-finance exports TVL:

arbitrum                  49.23 k

total                    49.23 k 

@waynebruce0x waynebruce0x merged commit d5d9d41 into DefiLlama:main Feb 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants