You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
template contains the raw, unformatted message body before any colorization or interpolation is applied. Useful for structured logging tools/visualizers like Sentry.
Hope I covered everything -- I'm available for changes if anything is off. 🙏🏻
Hey! Thank you very much for the PR. Sorry, once again, for the delay...
I'm just wondering: don't you also need *args (and **kwargs to a lesser extent) to be accessible in the template?
I'm thinking it could fix #1344 at the same time.
Heyo, no worries, thanks for getting back to me. 🙏🏻
I'm just wondering: don't you also need *args (and **kwargs to a lesser extent) to be accessible in the template?
I'm thinking it could fix #1344 at the same time.
That would be ideal, but wasn't sure if it was ok from your POV (in the original issue you only mentioned adding the template, so I assumed you wouldn't add the args/kwargs).
Happy to add it to the PR. What's the best way to go about it?
Add args (and potentially kwargs) additionally on the record alongside template
Make template a simple class with args, kwargs, and raw as attributes
Just from looking at the existing code, 2. would probably fit nicely?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
templatecontains the raw, unformatted message body before any colorization or interpolation is applied. Useful for structured logging tools/visualizers like Sentry.Hope I covered everything -- I'm available for changes if anything is off. 🙏🏻
Ref #1349