Skip to content

Add template to record#1413

Open
sentrivana wants to merge 1 commit intoDelgan:masterfrom
sentrivana:master
Open

Add template to record#1413
sentrivana wants to merge 1 commit intoDelgan:masterfrom
sentrivana:master

Conversation

@sentrivana
Copy link

@sentrivana sentrivana commented Nov 12, 2025

template contains the raw, unformatted message body before any colorization or interpolation is applied. Useful for structured logging tools/visualizers like Sentry.

Hope I covered everything -- I'm available for changes if anything is off. 🙏🏻

Ref #1349

@sentrivana sentrivana force-pushed the master branch 2 times, most recently from 0d011f2 to 6c4a328 Compare November 12, 2025 16:14
@Delgan
Copy link
Owner

Delgan commented Nov 30, 2025

Hey! Thank you very much for the PR. Sorry, once again, for the delay...

I'm just wondering: don't you also need *args (and **kwargs to a lesser extent) to be accessible in the template?
I'm thinking it could fix #1344 at the same time.

@sentrivana
Copy link
Author

Heyo, no worries, thanks for getting back to me. 🙏🏻

I'm just wondering: don't you also need *args (and **kwargs to a lesser extent) to be accessible in the template?
I'm thinking it could fix #1344 at the same time.

That would be ideal, but wasn't sure if it was ok from your POV (in the original issue you only mentioned adding the template, so I assumed you wouldn't add the args/kwargs).

Happy to add it to the PR. What's the best way to go about it?

  1. Add args (and potentially kwargs) additionally on the record alongside template
  2. Make template a simple class with args, kwargs, and raw as attributes

Just from looking at the existing code, 2. would probably fit nicely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants