Open
Conversation
added 2 commits
October 18, 2021 15:06
pavelgruba
reviewed
Oct 20, 2021
| } | ||
|
|
||
|
|
||
| function formatName(name: string): string { |
There was a problem hiding this comment.
Can we re-use prepareModuleName from module.facade-generator?
Contributor
Author
There was a problem hiding this comment.
No, can't. it first merged strings, and then camilized. And here i need first camilized and then merge. Also it add Module in the end, end i need one Module and one component
pavelgruba
reviewed
Oct 20, 2021
packages/devextreme-angular-generator/src/metadata-generator.ts
Outdated
Show resolved
Hide resolved
added 3 commits
October 21, 2021 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/HzUtQKx1/1060-add-reexports-to-wrapper-packages
devextreme-angular/dist/ui/vector-map/index.ts
must change generation of devextreme-angular/dist/index.ts (otherwise reexports from different files will clash