Skip to content

Update integration tests#1450

Open
psilabs-dev wants to merge 1 commit intoDifegue:devfrom
psilabs-dev:dev-integration-tests
Open

Update integration tests#1450
psilabs-dev wants to merge 1 commit intoDifegue:devfrom
psilabs-dev:dev-integration-tests

Conversation

@psilabs-dev
Copy link
Contributor

No new tests planned atm, instead I've stabilized the existing test cases and make conditions stricter.

  • Redis/docker connections will be explicitly closed on teardown when applicable.

The following updates apply to all Playwright UI tests:

  • All tests now explicitly create a browser context, and explicitly close context/browser within the scope of a test case.
  • All tests assert no errors when checking browser network inspector. This means that a UI test case will fail if the network inspector finds any LRR-side status code that isn't sub-400 or 401. Non-LRR origin URLs are excluded (e.g. Github rate limit errors will not trigger test case failure). This is a stricter client-side condition than expecting no server-side error logs, as 4xx validation errors and silent, server-side error responses will fail the test case. This will address a subset of upcoming OpenAPI integration testing failures, including the missing "/search" endpoint issue that escaped testing from earlier.

Log health assertions are occasionally capturing Shinobu error logs ("giving up adding it to the filesystem"); this is an existing race condition which can be ignored, or we can suppress it in the future test-side or LRR-side.

@psilabs-dev psilabs-dev force-pushed the dev-integration-tests branch from 7d1b138 to 1f09287 Compare January 23, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant