Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 2 issues raised during code review, which I'll explain below.
Issue 1:
add_toc_entryIf an exception happens, (supposedly judging from the code) a basic toc is still passed into Redis. However, an empty hash gets passed into the database, instead of
{"page": $title}. Also, otherwise the previous ops on toc wouldn't make much sense.There's another small issue outside of review. Suppose redis drops while in the try block, then hset will fail and put the process into the catch block. If redis comes back up during the catch block, then LRR will have erased the toc entry due to the database being unstable.
Issue 2:
build_jsonSince eval code already exists, then we might as well just account for the cases when eval fails.
Eval failure already means that none of the subsequent code should be executed. However, even if decode passes, we should probably check that we have a hash instead of
[].