Open
Conversation
amakarudze
requested changes
Jun 29, 2023
Contributor
amakarudze
left a comment
amakarudze
left a comment
There was a problem hiding this comment.
Sorry this took so long to be reviewed. I just suggested one change and we will merge this in. Thanks for your work on this!
en/homework/README.md
Outdated
| Time to do something similar, but for draft posts. | ||
|
|
||
| Let's add a link in `blog/templates/blog/base.html` in the header. We don't want to show our list of drafts to everybody, so we'll put it inside the `{% if user.is_authenticated %}` check, right after the button for adding new posts. | ||
| Let's add a link in the `<div class="page-header">` section of `blog/templates/blog/base.html`. We don't want to show our list of drafts to everybody, so we'll put it inside the `{% if user.is_authenticated %}` check, right after the button for adding new posts. |
Contributor
There was a problem hiding this comment.
I would just say Let's add a link in the page-header section of instead.
Member
There was a problem hiding this comment.
I would just say
Let's add a link in the page-header section ofinstead.
Would you like to commit this change to this PR's branch, @amakarudze?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all!
After attending a django-workshop, I started to further continue with the extended section of the tutorial.
There I stumbled upon the phrase:
Let's add a link in `blog/templates/blog/base.html` in the header.I was confused, because I associated the header section of the html file at first and did not think about. that the class definition of the div tag is meant.
My suggestion is to rephrase the sentence to make it more clear. What do you think?
Regards
Patrik