Add class based login required#117
Open
PabloLefort wants to merge 3 commits intoDjangoGirls:masterfrom
Open
Conversation
Member
|
Do any parts of the Django Girls tutorial or of the Django Girls tutorial extensions already use class-based views? (I couldn't find any.) If not, I'd say that this addition is out of scope for the Django Girls tutorial, which has the goal to provide detailed instructions on one way to do things (so that newcomers can follow), not to provide comprehensive documentation for all variants to do stuff. (The latter is what the official Django documentation and other resources are for). |
Member
|
On, and sorry for the long wait to get this reviewed. I've just resolved a trivial merge conflict that has come up since this PR was filed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use of
login_requiredas a method decorator