Edited Publish and Remove Buttons to use POST requests#189
Open
alexgit55 wants to merge 1 commit intoDjangoGirls:masterfrom
Open
Edited Publish and Remove Buttons to use POST requests#189alexgit55 wants to merge 1 commit intoDjangoGirls:masterfrom
alexgit55 wants to merge 1 commit intoDjangoGirls:masterfrom
Conversation
In the original code, the publish and remove buttons were still showing using regular buttons with <a> tags, despite the text suggesting the use of forms. I wanted to update the code to use forms for the correct functionality and be in line with what the description was saying
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original code, the publish and remove buttons were still showing using regular buttons with tags, despite the text suggesting the use of forms. I wanted to update the code to use forms for the correct functionality and align with the description. For me, it also made more sense to refresh the post_draft_list page instead of going to the post_detail page so I could quickly verify that the post had been published and removed from the draft list.