Autocomplete respect dropdownOptions. Fix placement when container is…#6602
Open
daniel-nelson wants to merge 2 commits intoDogfalo:v1-devfrom
healthline:autocomplete_dropdownOptions
Open
Autocomplete respect dropdownOptions. Fix placement when container is…#6602daniel-nelson wants to merge 2 commits intoDogfalo:v1-devfrom healthline:autocomplete_dropdownOptions
daniel-nelson wants to merge 2 commits intoDogfalo:v1-devfrom
healthline:autocomplete_dropdownOptions
Conversation
samschurter
added a commit
to samschurter/materialize
that referenced
this pull request
Nov 10, 2020
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… document.body
Proposed changes
Autocomplete should pass dropdownOptions to the dropdown. As described in #1385, Dropdown options can be used to customize the container used by Dropdown. Autocomplete is built on Dropdown, so should pass Dropdown options.
Our specific need for this is so that Autocomplete options don't get cut off within a modal.
Screenshots (if appropriate) or codepen:
Current v1.0.0 behavior:

With these changes, we can specify

dropdownOptions: { container: document.body },and get:Types of changes
Checklist: