Skip to content

fix: since and until params for getInbox request #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scottlovegrove merged 1 commit into from
Jan 29, 2026
Merged

fix: since and until params for getInbox request #72

scottlovegrove merged 1 commit into from
Jan 29, 2026

Conversation

@AfzalivE
Copy link
Member

@AfzalivE AfzalivE commented Jan 28, 2026

Doesn't look like we use since_ts_or_obj_idx and until_ts_or_obj_idx anywhere. The API docs say that these params should be newer_than_ts and older_than_ts respectively.

@AfzalivE AfzalivE changed the title fix: since and until params for getInbox fix: since and until params for getInbox request Jan 28, 2026
@scottlovegrove scottlovegrove merged commit c50eeb7 into main Jan 29, 2026
4 checks passed
@scottlovegrove scottlovegrove deleted the AfzalivE-patch-1 branch January 29, 2026 11:57
@github-actions github-actions bot mentioned this pull request Jan 29, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottlovegrove scottlovegrove scottlovegrove approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AfzalivE @scottlovegrove