feat!: add computed url property to main entity types #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `url: string` property (via Zod `.transform()`) to Channel, Thread, Comment, Conversation, ConversationMessage, and InboxThread schemas. The URL is computed at parse time using `getFullTwistURL`, so consumers get a ready-to-use Twist URL on every entity object with zero client code changes. Also fixes CommentSchema and ConversationMessageSchema to mark `workspaceId` and `channelId` as required (matching actual API responses). BREAKING CHANGE: Comment and ConversationMessage types now require `workspaceId` (and `channelId` for Comment) to be present. All entity types gain a non-optional `url` property. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnapse
added a commit
that referenced
this pull request
Feb 9, 2026
Regression from 1713fb9 (#76) which added `.transform()` to entity schemas but didn't update the batch descriptors for list endpoints. Single-entity endpoints (getThread, getComment, etc.) already included `schema` in their descriptors, but list endpoints (getInbox, getComments, getMessages, getConversations, getThreads, getChannels) returned `{ method, url, params }` without it — so the batch executor skipped the Zod parse and computed `url` properties were missing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
url: stringproperty to 6 entity schemas (Channel, Thread, Comment, Conversation, ConversationMessage, InboxThread) via Zod.transform(), giving consumers a ready-to-use Twist URL on every parsed entityworkspaceId/channelIdas required, matching actual API response behaviorSchema.parse()callsBREAKING CHANGE
CommentandConversationMessagetypes now requireworkspaceId(andchannelIdforComment) to be presenturlpropertyTest plan
npm run buildpassesurlproperty appears on entity types in consuming code (e.g.thread.url)🤖 Generated with Claude Code