fix(git-provider): allow all organization members to see git integrations#3509
Open
vtomasr5 wants to merge 1 commit intoDokploy:canaryfrom
Open
fix(git-provider): allow all organization members to see git integrations#3509vtomasr5 wants to merge 1 commit intoDokploy:canaryfrom
vtomasr5 wants to merge 1 commit intoDokploy:canaryfrom
Conversation
…ions Previously, git provider integrations (GitHub, GitLab, Bitbucket, Gitea) were only visible to the user who created them due to filtering by both organizationId and userId. This prevented other admins in the same organization from seeing or using shared integrations. Remove userId filtering from list queries and authorization checks so that all users in an organization can access git integrations created within that organization.
|
@Siumauricio any update to this pr ? sorry for asking we would just need the feature working asap in our organisation. cheers and thx for your work (+ thx @vtomasr5 for the possible fix) |
|
Would also love this feature now that you can have multiple admins it makes sense that you can also access the git integrations from other admin accounts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Previously, git provider integrations (GitHub, GitLab, Bitbucket, Gitea) were only visible to the user who created them due to filtering by both organizationId and userId. This prevented other admins in the same organization from seeing or using shared integrations.
Remove userId filtering from list queries and authorization checks so that all users in an organization can access git integrations created within that organization.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #3489
Screenshots (if applicable)