Skip to content

Add syncRedirectDomain for vercel.com template#577

Merged
pawel-kow merged 1 commit intoDomain-Connect:masterfrom
RhysSullivan:master
Feb 2, 2025
Merged

Add syncRedirectDomain for vercel.com template#577
pawel-kow merged 1 commit intoDomain-Connect:masterfrom
RhysSullivan:master

Conversation

@RhysSullivan
Copy link
Contributor

Description

I should've read the Some common feedback part of the docs my bad. Was doing the implementation and realized I'd need syncRedirectDomain so this is updating the template to support that. Thanks for the quick review on the last one

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

Example variable values

<-- to make review process easier please provide example set of variable values for this template -->

<-- Example: -->

var1: aaa
var2: foo.com

<-- Or provide the whole testData object from the Online Editor after testing and using "Add as test" button -->

"testData": {
    "testset": {
      "variables": {
        "domain": "example.com",
        "host": "foo",
        "example": "bar"
      },
      "results": [
        {
          "type": "TXT",
          "name": "foo",
          "ttl": 86400,
          "data": "\"bar\""
        }
      ]
    }
  }

@github-actions
Copy link

github-actions bot commented Feb 1, 2025

Linter OK:

Linter result for vercel.com.website.json

Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pawel-kow pawel-kow added this pull request to the merge queue Feb 2, 2025
Merged via the queue into Domain-Connect:master with commit f0c4b45 Feb 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments