fix: reject Promises with Error objects#213
Open
kpcurai wants to merge 1 commit intoDonaldcwl:devfrom
Open
Conversation
|
Any chance to get this merged ? I'm experiencing the same issue mentioned in #211 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #211.
Certain browsers (I've observed it in DuckDuckGo Mobile 5) will throw an error if a Promise is rejected with a non-Error object. HTMLElements call
onerrorwith an Event subclass argument, not an error object, so this is causing some noise and losing context for debugging.