i#6536: eliminate the instability of detachment on x86-64 platform#6579
Open
onroadmuwl wants to merge 18 commits intoDynamoRIO:masterfrom
Open
i#6536: eliminate the instability of detachment on x86-64 platform#6579onroadmuwl wants to merge 18 commits intoDynamoRIO:masterfrom
onroadmuwl wants to merge 18 commits intoDynamoRIO:masterfrom
Conversation
Contributor
|
I re-ran the x86-64 job and the detach test still fails: I also took this patch and ran it locally and it fails there too in the same way. |
Contributor
|
I see more changes were made since Derek's last comment. When this PR is ready for a re-review, please use the Github UI to signal that (see list of reviewers on top-right side of the page). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print the done in detach_test.dll.c instead of infloop.c.
Fixes: #6536