Skip to content

i#7731: Optimize reuse distance collection using splay tree #7732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artur-abd wants to merge 17 commits into
base: master
Choose a base branch
from
+595 −238
Open

i#7731: Optimize reuse distance collection using splay tree #7732

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1b8aa74
i#7731:Optimize reuse distance using splay tree
artur-abd Nov 27, 2025
403bdf2
i#7731: fix descriptions
artur-abd Dec 1, 2025
721fbdd
Merge 'master' into i7731-optimize-reuse-distance
artur-abd Jan 23, 2026
7f21383
i#7731: Deprecate options for skip list
artur-abd Jan 22, 2026
eccaeaf
i#7731: Removed deprecated arguments
artur-abd Jan 22, 2026
dcafa9f
i#7731: Added tests for splay tree
artur-abd Jan 23, 2026
b62f4cf
i#7731: Fixed codestyle
artur-abd Jan 23, 2026
bffec90
i#7731: Fixed a test for splay tree
artur-abd Jan 23, 2026
1ebbd03
i#7731: Fixed typo
artur-abd Jan 23, 2026
7d1dd87
i#7731: Fixed typo
artur-abd Jan 23, 2026
a5e2a8e
i#7731: Removed unused include
artur-abd Jan 23, 2026
940a0d6
i#7731: Fixed droption output & marked skip_verify as deprecated
artur-abd Jan 23, 2026
0924683
i#7731: Fixed codestyle
artur-abd Jan 23, 2026
7af338a
i#7731: Separated tests for splay tree
artur-abd Jan 23, 2026
0504768
i#7731: Fixed codestyle
artur-abd Jan 23, 2026
047689c
i#7731: Fixed double free of nodes in tests
artur-abd Jan 23, 2026
afda315
i#7731: Fixed codestyle
artur-abd Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions clients/drcachesim/tools/reuse_distance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ reuse_distance_t::shard_data_t::shard_data_t(uint64_t reuse_threshold, uint64_t
uint32_t distance_limit, bool verify)
: distance_limit(distance_limit)
{
ref_list = std::unique_ptr<line_ref_list_t>(
new line_ref_list_t(reuse_threshold, skip_dist, verify));
ref_list = std::unique_ptr<line_ref_splay_t>(
new line_ref_splay_t(reuse_threshold, skip_dist, verify));
}

bool
Expand Down Expand Up @@ -166,12 +166,12 @@ reuse_distance_t::parallel_shard_memref(void *shard_data, const memref_t &memref
++shard->data_refs;
}
addr_t tag = memref.data.addr >> line_size_bits_;
std::unordered_map<addr_t, line_ref_t *>::iterator it =
std::unordered_map<addr_t, line_ref_node_t *>::iterator it =
shard->cache_map.find(tag);
if (it == shard->cache_map.end()) {
line_ref_t *ref = new line_ref_t(tag);
line_ref_node_t *ref = new line_ref_node_t(tag);
// insert into the map
shard->cache_map.insert(std::pair<addr_t, line_ref_t *>(tag, ref));
shard->cache_map.insert(std::pair<addr_t, line_ref_node_t *>(tag, ref));
// insert into the list
shard->ref_list->add_to_front(ref);
// See if the line we're adding was previously removed.
Expand Down Expand Up @@ -237,8 +237,8 @@ cmp_dist_key(const reuse_distance_t::distance_map_pair_t &l,
}

static bool
cmp_total_refs(const std::pair<addr_t, line_ref_t *> &l,
const std::pair<addr_t, line_ref_t *> &r)
cmp_total_refs(const std::pair<addr_t, line_ref_node_t *> &l,
const std::pair<addr_t, line_ref_node_t *> &r)
{
if (l.second->total_refs > r.second->total_refs)
return true;
Expand All @@ -252,8 +252,8 @@ cmp_total_refs(const std::pair<addr_t, line_ref_t *> &l,
}

static bool
cmp_distant_refs(const std::pair<addr_t, line_ref_t *> &l,
const std::pair<addr_t, line_ref_t *> &r)
cmp_distant_refs(const std::pair<addr_t, line_ref_node_t *> &l,
const std::pair<addr_t, line_ref_node_t *> &r)
{
if (l.second->distant_refs > r.second->distant_refs)
return true;
Expand Down Expand Up @@ -324,15 +324,15 @@ reuse_distance_t::print_shard_results(const shard_data_t *shard)
std::cerr << "\n";
std::cerr << "Reuse distance threshold = " << knobs_.distance_threshold
<< " cache lines\n";
std::vector<std::pair<addr_t, line_ref_t *>> top(knobs_.report_top);
std::vector<std::pair<addr_t, line_ref_node_t *>> top(knobs_.report_top);
std::partial_sort_copy(shard->cache_map.begin(), shard->cache_map.end(), top.begin(),
top.end(), cmp_total_refs);
std::cerr << "Top " << top.size() << " frequently referenced cache lines\n";
std::cerr << std::setw(18) << "cache line"
<< ": " << std::setw(17) << "#references " << std::setw(14)
<< "#distant refs"
<< "\n";
for (std::vector<std::pair<addr_t, line_ref_t *>>::iterator it = top.begin();
for (std::vector<std::pair<addr_t, line_ref_node_t *>>::iterator it = top.begin();
it != top.end(); ++it) {
if (it->second == NULL) // Very small app.
break;
Expand All @@ -350,7 +350,7 @@ reuse_distance_t::print_shard_results(const shard_data_t *shard)
<< ": " << std::setw(17) << "#references " << std::setw(14)
<< "#distant refs"
<< "\n";
for (std::vector<std::pair<addr_t, line_ref_t *>>::iterator it = top.begin();
for (std::vector<std::pair<addr_t, line_ref_node_t *>>::iterator it = top.begin();
it != top.end(); ++it) {
if (it->second == NULL) // Very small app.
break;
Expand Down Expand Up @@ -484,11 +484,11 @@ reuse_distance_t::get_aggregated_results()
}
for (const auto &entry : shard.second->cache_map) {
const auto &existing = aggregated_results_->cache_map.find(entry.first);
line_ref_t *ref;
line_ref_node_t *ref;
if (existing == aggregated_results_->cache_map.end()) {
ref = new line_ref_t(entry.first);
ref = new line_ref_node_t(entry.first);
aggregated_results_->cache_map.insert(
std::pair<addr_t, line_ref_t *>(entry.first, ref));
std::pair<addr_t, line_ref_node_t *>(entry.first, ref));
ref->total_refs = 0;
} else {
ref = existing->second;
Expand All @@ -507,7 +507,7 @@ reuse_distance_t::print_results()
std::cerr << TOOL_NAME << " aggregated results:\n";
print_shard_results(get_aggregated_results());

// For regular shards the line_ref_t's are deleted in ~line_ref_list_t.
// For regular shards the line_ref_node_t's are deleted in ~line_ref_splay_t.
for (auto &iter : get_aggregated_results()->cache_map) {
delete iter.second;
}
Expand Down
Loading
Loading