Fix unassigned split variable in wrapCircuit function#316
Open
SushankMishra wants to merge 1 commit intoECSHackWeek:mainfrom
Open
Fix unassigned split variable in wrapCircuit function#316SushankMishra wants to merge 1 commit intoECSHackWeek:mainfrom
SushankMishra wants to merge 1 commit intoECSHackWeek:mainfrom
Conversation
'Split' variable remains unassigned without the explicit assignment in selective cases and is referenced before assignment in the iterative loop on line 330. Fixed through the given explicit assignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix prevents runtime errors during circuit fitting and improves the stability and usability of the package for both simple and complex circuit strings.
Really excited to contribute to this essential package — hope to continue improving it further!