Initial proof-of-concept for dynamic HiPO loading in highspy#2755
Draft
mathgeekcoder wants to merge 1 commit intoERGO-Code:latestfrom
Draft
Initial proof-of-concept for dynamic HiPO loading in highspy#2755mathgeekcoder wants to merge 1 commit intoERGO-Code:latestfrom
mathgeekcoder wants to merge 1 commit intoERGO-Code:latestfrom
Conversation
Contributor
Author
|
I'm not wanting to push this code. It's more for a reference for @galabovaa |
Contributor
Author
|
Note: this currently might have issues with static variables or thread local storage (e.g., the parallel code) since the highspy-hipo library is currently duplicating the dependent code that is also used in highspy. The HiPO library can be made dependent on highspy/libhighs (without duplication) - even though highspy/libhighs can dynamically load the HiPO library. It's not quite a circular dependency, but need to take care. I might look at this next week. |
Contributor
|
Thank you, @mathgeekcoder I opened #2756 just for reference, what I had so far for the highs with hipo wheel and tests of both highspy wheels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick and nasty proof-of-concept for dynamic loading of HiPO in
highspy.highspy-hipowheel, which is dependent onhighspyhighspyhas an optional dependency onhighspy-hipopip install highspy[hipo]At runtime, highs will dynamically check to see if the highs-hipo.dll (or .so etc.) library is available. If so, it will load the appropriate function pointer address and hook everything up. Otherwise, HiPO is disabled.
It also performs a sanity version check to make sure
highspyandhighspy-hipoare the same version to prevent issues.The PATH lookup is a little bit of a hack at the moment.
highspy-hipo, which is called byis_hipo_availableinhighspyAs it stands, it mostly works. It correctly identifies if the library is installed and makes the appropriate calls. I had some issues with BLAS crashing that I haven't looked into yet.