fix FV frontogenesis bug and diagnostic PS/PSDRY bug in SE log file#1467
fix FV frontogenesis bug and diagnostic PS/PSDRY bug in SE log file#1467PeterHjortLauritzen wants to merge 2 commits intoESCOMP:cam_developmentfrom
Conversation
| pty(i,k,j) = pty(i,k,j) / aearth | ||
| ! | ||
| ! Topography correction term: | ||
| ! Horizontal temperature gradient for fronotogenesis function was originally computed over |
There was a problem hiding this comment.
Is it currently being computed over terrain-following coordinates and then correction terms applied? If so, I would change this from was to is. I believe this is the case. If on the other hand, this is talking about how things were computed prior to this PR, we typically do not have comments like that in the code.
There was a problem hiding this comment.
120-121 is terrain following.
127-128 is the correction terms.
There was a problem hiding this comment.
With that info, my request is to change was to is in this sentence
There was a problem hiding this comment.
@PeterHjortLauritzen - if you make this minor comment update, I believe this PR is ready to go, correct?
There was a problem hiding this comment.
Comment beautified!
3 participants
Fix bug in frontogenesis function for FV dycore: partially closes #1414
(science tested by ACOM; there will be namelist changes to re-tune QBO with the fixed frontogenesis function)
@fvitt @mbramberger @tilmes @chihchen24
Minor bug fix for diagnoatics written to log file with spectral-element dynamical core (PS and PSDRY are missing the pressure at model top).