Include chemical heating in mid-top chemistry compsets#1478
Open
fvitt wants to merge 9 commits intoESCOMP:cam_developmentfrom
Open
Include chemical heating in mid-top chemistry compsets#1478fvitt wants to merge 9 commits intoESCOMP:cam_developmentfrom
fvitt wants to merge 9 commits intoESCOMP:cam_developmentfrom
Conversation
modified: src/chemistry/mozart/mo_jeuv.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/chem_mech.doc modified: src/chemistry/pp_trop_strat_mam5_ts4/chem_mech.in modified: src/chemistry/pp_trop_strat_mam5_ts4/chem_mods.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/m_rxt_id.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/m_spc_id.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/mo_adjrxt.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/mo_indprd.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/mo_lin_matrix.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/mo_lu_factor.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/mo_lu_solve.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/mo_nln_matrix.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/mo_phtadj.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/mo_prod_loss.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/mo_rxt_rates_conv.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/mo_setrxt.F90 modified: src/chemistry/pp_trop_strat_mam5_ts4/mo_sim_dat.F90 modified: src/chemistry/pp_waccm_t4ma_mam5/chem_mech.doc modified: src/chemistry/pp_waccm_t4ma_mam5/chem_mech.in modified: src/chemistry/pp_waccm_t4ma_mam5/chem_mods.F90 modified: src/chemistry/pp_waccm_t4ma_mam5/m_spc_id.F90 modified: src/chemistry/pp_waccm_t4ma_mam5/mo_indprd.F90 modified: src/chemistry/pp_waccm_t4ma_mam5/mo_lin_matrix.F90 modified: src/chemistry/pp_waccm_t4ma_mam5/mo_lu_factor.F90 modified: src/chemistry/pp_waccm_t4ma_mam5/mo_lu_solve.F90 modified: src/chemistry/pp_waccm_t4ma_mam5/mo_nln_matrix.F90 modified: src/chemistry/pp_waccm_t4ma_mam5/mo_prod_loss.F90 modified: src/chemistry/pp_waccm_t4ma_mam5/mo_rxt_rates_conv.F90 modified: src/chemistry/pp_waccm_t4ma_mam5/mo_setrxt.F90 modified: src/chemistry/pp_waccm_t4ma_mam5/mo_sim_dat.F90
modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/use_cases/hist_trop_strat_t4s_cam7.xml modified: src/chemistry/mozart/mo_waccm_hrates.F90
modified: bld/namelist_files/namelist_defaults_cam.xml
renamed: src/chemistry/pp_trop_strat_mam5_vbs -> src/chemistry/pp_trop_strat_mam5_t1s1 renamed: src/chemistry/pp_trop_strat_mam5_ts2 -> src/chemistry/pp_trop_strat_mam5_t2s1 renamed: src/chemistry/pp_trop_strat_mam5_ts4 -> src/chemistry/pp_trop_strat_mam5_t4s2 new file: src/chemistry/pp_trop_strat_mam5_t1s2 modified: bld/build-namelist modified: bld/config_files/definition.xml modified: bld/configure modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/use_cases/hist_trop_strat_nudged_cam6.xml modified: cime_config/config_component.xml modified: cime_config/config_compsets.xml
modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/use_cases/hist_trop_strat_nudged_cam6.xml modified: bld/namelist_files/use_cases/hist_trop_strat_t4s_cam7.xml modified: cime_config/config_component.xml modified: cime_config/config_compsets.xml
cacraigucar
requested changes
Feb 3, 2026
bld/build-namelist
Outdated
| add_default($nl, 'megan_mapped_emisfctrs', 'val'=>'.false.'); | ||
| } | ||
| if ($chem =~ /trop_strat_mam4_vbs/ or $chem =~ /trop_strat_mam5_vbs/) { | ||
| if ($chem =~ /trop_strat_mam4_vbs/ or $chem =~ /trop_strat_mam5_vbs/ or $chem =~ /trop_strat_mam5_t1s/) { |
Collaborator
There was a problem hiding this comment.
It appears that trop_strat_mam5_vbs is being phased out/renamed and this should be removed.
Also, namelist_definition.xml still has reference to trop_strat_mam5_vbs as well
Collaborator
|
@tilmes - I will need to have a review from you as well before Francis can proceed with tagging this PR. That or you can remove yourself as a reviewer |
tilmes
approved these changes
Feb 3, 2026
Collaborator
tilmes
left a comment
tilmes
left a comment
There was a problem hiding this comment.
I have briefly check the code, and agree that we only change the L93 MT -cam7 physics case for now to T4S2 and T1S2, while all the other vert. resoluitons will not be changed.
modified: bld/build-namelist modified: bld/namelist_files/namelist_definition.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes chemical heating in mid-top compsets. This is done by including reactions needed for chemical heating in the middle atmosphere which is achieved via waccm physics.
Closes #1476
Here we adopt
S1for stratospheric chemistry used in low-top configurations,S2for stratospheric chemistry used in mid-top configurations.