Convert the BareGroundFluxesMod dewpoint calculation into a function#3706
Open
olyson wants to merge 1 commit intoESCOMP:b4b-devfrom
Open
Convert the BareGroundFluxesMod dewpoint calculation into a function#3706olyson wants to merge 1 commit intoESCOMP:b4b-devfrom
olyson wants to merge 1 commit intoESCOMP:b4b-devfrom
Conversation
olyson
added
the
next
wwieder
reviewed
Jan 28, 2026
| @@ -559,4 +544,38 @@ subroutine BareGroundFluxes(bounds, num_noexposedvegp, filter_noexposedvegp, & | |||
|
|
|||
| end subroutine BareGroundFluxes | |||
Contributor
There was a problem hiding this comment.
Way to go @olyson, this seems to be a b4b refactor that cleans up the code by creating a function for dew and frost over bare ground. Assuming this is really b4b can we just merge the PR to b4b_dev?
wwieder
reviewed
Jan 28, 2026
| ! DESCRIPTION: | ||
| ! Calculates dewpoint (degK) from input vapor pressure | ||
| ! Uses Equation 7 from Lawrence 2005, https://doi.org/10.1175/BAMS-86-2-225 | ||
|
|
Contributor
There was a problem hiding this comment.
Do we also need to update our documentation to reflect this?
Contributor
Author
There was a problem hiding this comment.
I will open an issue for the documentation. I'll also open an issue to document #3643
Contributor
|
as with #3710, what's an appropriate milestone here alpha08d or beta09? |
Contributor
|
@ekluzek this one didn't come up in our sprint conversation today, but is it a simple task you can merge to b4b-dev? |
Contributor
wwieder
removed
the
next
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Convert the BareGroundFluxesMod dewpoint calculation into a function
Specific notes
Per a discussion we had about modularizing new code, I decided to see how long it would take me to convert the dewpoint calculation recently incorporated into BareGroundFluxesMod (#3688) into a function (not long). Interestingly, the version of BareGroundFluxesMod presented here is actually what @hannay is using as a SourceMod in new CESM3 development simulations. I had pointed her to my branch instead of a separate location for the code mods.
Contributors other than yourself, if any: @ekluzek for suggestion to convert to a function
CTSM Issues Fixed (include github issue #): Addresses in part #3694
Are answers expected to change (and if so in what way)? No.
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No. No.
Testing performed, if any:
This function is bfb with previous tests related to #3688, at least for a 1 year I2000 SP case.