Skip to content

feat: Custom Structure chart parser#27

Draft
Eatham532 wants to merge 3 commits intomainfrom
feat-structure-charts
Draft

feat: Custom Structure chart parser#27
Eatham532 wants to merge 3 commits intomainfrom
feat-structure-charts

Conversation

@Eatham532
Copy link
Owner

No description provided.

Signed-off-by: Eatham532 <78714349+Eatham532@users.noreply.github.com>
Signed-off-by: Eatham532 <78714349+Eatham532@users.noreply.github.com>
Removed structure chart custom fence from mkdocs configuration.
@cedar-debater
Copy link

just for reference, here is what it currently looks like
image
image
image
image
image
image
image
image
image

immediate feedback

  1. do not allow a child node to have multiple parent nodes
  2. no line crossing
  3. you need some standard way to represent the group of "data flow & label", and a way for collision detection, and also fitting enough space.

i'd personally implement it by trying a very small scale, then haviing the code progressively scale up if it overlaps or has like 5 rows of data flows on top of the lines

im just not feeling very motivated to review the code rn sorry

Copy link

@cedar-debater cedar-debater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait why specifically put emojis in




image

NOOO INCONSISTENCY MY ONLY WEAKNESS /j

(actual somewhat code review at #27 (comment) )

@cedar-debater
Copy link

WHAT DO YOU MEAN IT JUST PUTS COMMENTS IN THE SAME PR DISCUSSION???

nvm ig

@Eatham532
Copy link
Owner Author

Haha thanks for looking over this. Right now this pr was just experimental. Because i had no time to put effort in doing stuff myself (exams etc) i had an agent do stuff and it was experimental.

Also, im pretty sure a child can and should have multiple parent nodes. The example in the demo run is a good example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants