Conversation
samholmes
approved these changes
Oct 31, 2025
Contributor
samholmes
left a comment
There was a problem hiding this comment.
Small nit to make sure that we locate the 'wire' payment type in a SUPPORTED_PAYMENT_TYPE constant.
| } | ||
|
|
||
| // Global constraints pre-check | ||
| const paymentTypes: FiatPaymentType[] = ['wire'] |
Contributor
There was a problem hiding this comment.
Make 'wire' a constant at the top of the module and use it here and in the RampQuote instances
| const quoteConstraintOk = validateRampQuoteRequest( | ||
| pluginId, | ||
| request, | ||
| 'wire' |
Contributor
There was a problem hiding this comment.
Re-use a constant for this 'wire' value.
Pending Master Services Agreement approval
7b2eff0 to
9232762
Compare
Contributor
|
@Jon-edge also line 525 needs treatment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending Master Services Agreement approval
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Disables the
infiniteramp via global constraints and adds constraint-based pre-checks (defaultwire) to Infinite’s support and quote flows.infiniteprovider insrc/plugins/ramps/rampConstraints.ts.src/plugins/ramps/infinite/infiniteRampPlugin.ts)validateRampCheckSupportRequestandvalidateRampQuoteRequest.DEFAULT_PAYMENT_TYPEaswireand use it in support/quote validation.Written by Cursor Bugbot for commit 9232762. This will update automatically on new commits. Configure here.