Skip to content

Devalih/204 208 226 #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
devalih wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Devalih/204 208 226 #244

devalih wants to merge 3 commits into from

Conversation

@devalih
Copy link
Contributor

@devalih devalih commented Nov 22, 2020

Description

TASK: ASANA LINK

Add a description of your changes here.

Notes

  • Example: This PR will not address x,y, and z, because of a, b, and c.

Testing

  • i18n
  • RTL
  • safecommit shows 0 violations
  • Unit, integration, acceptance tests as appropriate
  • Performance
  • Database migrations are backwards-compatible

Related PRs

@devalih devalih force-pushed the devalih/204-208-226 branch from f33d001 to 25f7ab1 Compare November 22, 2020 10:27
@shadinaif shadinaif self-requested a review November 22, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shadinaif shadinaif shadinaif approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devalih @shadinaif