ensure the existence of outputs after persist#80
Open
senbaikang wants to merge 6 commits intoEliHei2:mainfrom
Open
ensure the existence of outputs after persist#80senbaikang wants to merge 6 commits intoEliHei2:mainfrom
senbaikang wants to merge 6 commits intoEliHei2:mainfrom
Conversation
Owner
|
Thanks for the contribution @senbaikang! I'm reviewing this, this is similar to the idea of |
Author
|
Thank you for reviewing it! For the original code I encounter an error of inexistent output files for the prediction step, hence the small fix. Hope it helps and feel free to improve! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the prediction step, some outputs in parquet format are saved locally in a non-blocking way using dask's persist function. Afterwards these files are accessed, but there's no guarantee that they have been fully saved on disk. I added a simple fix to it, though there might be a better way.