refactor: major template engine refactor (AST-based)#27
Open
Farrael wants to merge 10 commits intoElliesaur:mainfrom
Open
refactor: major template engine refactor (AST-based)#27Farrael wants to merge 10 commits intoElliesaur:mainfrom
Farrael wants to merge 10 commits intoElliesaur:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a complete rewrite of how templates are parsed and processed.
Templates are now compiled into an AST, producing:
These structures are cached to improve performance when updating values, without having to re-parse or rebuild the template (as long as the template itself or the component set doesn’t change).
What changed
AST-based processing
Components as real elements
$childrenis exposed as a string inside component templatesExample:
Improved variable system
Functions in variables
callFunctionWithArgumentsfor examples.Each improvements
{{#each $items item}}{{$key}} instead of {{$item.key}}…but only if it does not shadow an existing variable. (using the same name as a declared one)
Breaking changes
Variable declaration
$.❌ Old:
{{#if variable ...}}✅ New:
{{#if $variable ...}}Component syntax change
❌ Old:
{{@special:foo=bar}}✅ New:
Children support
{{$children}}Tip
$childrenis a string already parsed and resolvedVariable resolution rules
Tests
Example
Notes
kelpyalso work on a rework of components and parsing