Open
Conversation
Breakpad has the ability to generate a dump on demand, not just on a crash. This is exposed through a new `write_minidump` method added to the `BreakpadHandler` object. This requires adding an assembly file to the compilation for the linux targets.
All the "crash" terminology is confusing now that dumps can be generated on demand, so rename those to "dump".
Since a dump can now be generated outside of fatal crashes, we want the sentry client to keep running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
It can be useful to generate a minidump of a program not only on crashes, but also on demand, when we can detect an invalid situation and want to generate a dump to be able to investigate it in details. Breakpad has this ability, so this MR simply exposes this through the Rust API.
Description of Changes
A new
BreakpadHandler::generate_minidumphelper is added to generate a minidump on demand. The code is reworked and reworded to function with non fatal dumps.