Do not free EmbPattern we did not create in emb_pattern_{read,write}Auto#241
Open
norriscm wants to merge 1 commit intoEmbroidermodder:mainfrom
Open
Do not free EmbPattern we did not create in emb_pattern_{read,write}Auto#241norriscm wants to merge 1 commit intoEmbroidermodder:mainfrom
norriscm wants to merge 1 commit intoEmbroidermodder:mainfrom
Conversation
emb_pattern_{read,write}Auto take an EmbPattern * that was created by the caller, which the caller is responsible for freeing. The error handler for unsupported format, however, was freeing the pattern, leading to a double-free when the caller tries to free the pattern. Remove the erroneous calls to emb_pattern_free.
I checked all functions that call emb_pattern_free to confirm that they only free patterns that they created; they are good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emb_pattern_{read,write}Auto take an EmbPattern * that was created by the caller, which the caller is responsible for freeing. The error handler for unsupported format, however, was freeing the pattern, leading to a double-free when the caller tries to free the pattern. Remove the erroneous calls to emb_pattern_free.
I checked all functions that call emb_pattern_free to confirm that they only free patterns that they created; they are good.