Skip to content

Perf: improve sum like reductions #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wsmoses wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Perf: improve sum like reductions #2865

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87a4e02
Perf: improve sum like reductions
wsmoses Dec 27, 2025
2614f6c
Update interpreter.jl
wsmoses Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/compiler/interpreter.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,8 +992,26 @@ end
@inline function override_bc_mapreduce(f, op, ::Base.IndexLinear, A::Base.AbstractArrayOrBroadcasted)
inds = Base.LinearIndices(A)
n = length(inds)

HET = Base.IteratorEltype(A)
if HET isa Base.HasEltype
ET = eltype(A)
if (op === Base.:+ || op === Base.add_sum) && Base.isconcretetype(ET) && (ET <: Base.IEEEFloat || ET <: Complex{<:Base.IEEEFloat})
@inbounds i = first(inds)
@inbounds l = last(inds)
s = zero(ET)
while i <= l
@inbounds Ai = A[i]
i+=1
s = op(s, f(Ai))
@simdloop
end
return s
end
end

if n == 0
return Base.mapreduce_empty_iter(f, op, A, Base.IteratorEltype(A))
return Base.mapreduce_empty_iter(f, op, A, HET)
elseif n == 1
@inbounds a1 = A[first(inds)]
return Base.mapreduce_first(f, op, a1)
Expand Down
Loading