Implement more client-sided autocomplete suggestions#1876
Draft
StayBlue wants to merge 3 commits intoEpix-Incorporated:masterfrom
Draft
Implement more client-sided autocomplete suggestions#1876StayBlue wants to merge 3 commits intoEpix-Incorporated:masterfrom
StayBlue wants to merge 3 commits intoEpix-Incorporated:masterfrom
Conversation
Contributor
Author
|
I'm marking this as a draft since I don't have proof-of-functionality yet. I would also like to get some eyes on this to see where I should take it from here. |
350ed74 to
e885e52
Compare
e885e52 to
44c3561
Compare
Contributor
Author
|
This PR hasn't received as much visibility as I had hoped, so I will unmark it as a draft. However, it shouldn't be merged until there's more feedback on it. |
The changes to players was made because there are likely a lot of plugins and other commands out there in the wild that have the players argument in different formats, so instead of making them all lose autocomplete suggestions, this opts to try to cover most of the common formats.
Contributor
Author
|
Proof-of-functionality: |
Member
RobloxStudioBeta_eDvSf1ASEm.mp4it's doing this whenever i click tab, either removing the player name or switching to a different command |
Member
|
Merge conflict :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part two of my original PR #1853, and an implementation of the suggestion in my issue #1353 (for at least the client-side portion).
The initial goal of that issue was mainly to handle the client-side, so if anyone ever wants to tackle that problem themselves, they can (but I probably won't).
This PR has both good and bad aspects.
The good:
The bad:
ParseArgfunction.Autocompletefunction.