Ensure console keybind respects chat by totallytavi · Pull Request #1989 · Epix-Incorporated/Adonis

totallytavi · 2025-09-19T20:55:16Z

Roblox has recently introduced a change that results in ContextActionService ignoring chat inputs. CoreGui is made nil, so CAS won't properly detect that the events are game processed events.

See this DevForum thread: https://devforum.roblox.com/t/userinputservicegetfocusedtextbox-returns-nil-with-the-chat-box-focused/3940424

Minimum reproducible example

Since CodeRabbit is so angry I didn't do this.

local UserInputService = game:GetService("UserInputService")
local TextChatService = game:GetService("TextChatService")

UserInputService.InputBegan:Connect(function(input: InputObject, gameProcessedEvent: boolean)
	if input.KeyCode ~= Enum.KeyCode.Quote then
		return
	end
	
	print(
		'Quote key processed',
		gameProcessedEvent and "GPE" or "Non-GPE",
		TextChatService.ChatInputBarConfiguration.IsFocused and "Focused" or "Not-Focused",
                UserInputService:GetFocusedTextBox() and "Textbox" or "No-Textbox"
	)
end)

Summary by CodeRabbit

Bug Fixes
- Improved keyboard input handling across UI themes: console toggle and key-driven panels now ignore input when chat or text boxes are focused, preventing unintended toggles.
- Tab and other key interactions for player list, settings, and user panel now respect chat input focus and game-processed events for more reliable behavior.

ari-party · 2025-09-22T16:44:54Z

Adonis/MainModule/Client/UI/Default/Settings.luau

Line 117 in 2d505fe

local textbox = service.UserInputService:GetFocusedTextBox()

Adonis/MainModule/Client/UI/Aero/PlayerList.rbxmx

Line 361 in 2d505fe

local textbox = service.UserInputService:GetFocusedTextBox()

Adonis/MainModule/Client/UI/Default/UserPanel.luau

Line 1056 in 2d505fe

local textbox = service.UserInputService:GetFocusedTextBox()

Adonis/MainModule/Client/UI/Default/PlayerList.rbxmx

Line 346 in 2d505fe

local textbox = service.UserInputService:GetFocusedTextBox()

totallytavi · 2025-09-22T18:29:31Z

Thanks for pointing out the ones I missed @ari-party. I'll submit some more fixes for this later

GalacticInspired · 2025-10-04T23:17:23Z

Wasn't this already fixed by simply checking gameProcessedEvent?
#1984

totallytavi · 2025-10-07T16:39:34Z

Potentially, let me see.

GalacticInspired · 2025-10-13T12:50:29Z

Potentially, let me see.

Hi, have you managed to check this out yet?

totallytavi · 2025-10-15T18:46:35Z

I opened a baseplate and had a weird issue with Adonis. I'll see if I can make a reproducible example

totallytavi · 2025-10-22T16:42:25Z

@GalacticInspired
Seems to fix it, since Roblox will mark the event as a gameProcessedEvent. I don't trust that Roblox will keep this so just for safety, I'll implement both GPE and IsFocused in my PR

local UserInputService = game:GetService("UserInputService")
local TextChatService = game:GetService("TextChatService")

UserInputService.InputBegan:Connect(function(input: InputObject, gameProcessedEvent: boolean)
	if input.KeyCode ~= Enum.KeyCode.Quote then
		return
	end
	
	print(
		'Quote key processed',
		gameProcessedEvent and "GPE" or "Non-GPE",
		TextChatService.ChatInputBarConfiguration.IsFocused and "Focused" or "Not-Focused"
	)
end)

totallytavi · 2025-10-22T16:47:58Z

As @ari-party pointed out, #1984 didn't account for a few other UIs so I'll drop that into my PR as well

* Ensure textbox is a boolean in checks * Add fallback of false for all checks * Add gameProcessedEvent to checks

* Add logic to check for all instances needed * Add fallback in the event none exist * Remove unneeded "or false" from textbox check

Expertcoderz

Looks good overall, just some minor issues. I'm not exactly sure if this PR should be merged (considering that the underlying issue has been fixed by #1984), so I'll leave it open for others to comment.

Expertcoderz · 2025-11-12T03:56:06Z

MainModule/Client/UI/Aero/Console.rbxmx

 	BindEvent(service.UserInputService.InputBegan, function(InputObject, gameProcessedEvent)
-		local textbox = service.UserInputService:GetFocusedTextBox()
-		if not textbox and not gameProcessedEvent and rawequal(InputObject.UserInputType, Enum.UserInputType.Keyboard) and InputObject.KeyCode.Name == (client.Variables.CustomConsoleKey or consoleKey) then
+		local textbox = service.UserInputService:GetFocusedTextBox() ~= nil


Consider renaming textbox to textboxFocused for clarity.

Will do that. VSC can probably search and replace

Expertcoderz · 2025-11-12T03:56:11Z

MainModule/Client/UI/Aero/Console.rbxmx

-		local textbox = service.UserInputService:GetFocusedTextBox()
-		if not textbox and not gameProcessedEvent and rawequal(InputObject.UserInputType, Enum.UserInputType.Keyboard) and InputObject.KeyCode.Name == (client.Variables.CustomConsoleKey or consoleKey) then
+		local textbox = service.UserInputService:GetFocusedTextBox() ~= nil
+		local chatFocused = service.TextChatService and service.TextChatService.ChatInputBarConfiguration and service.TextChatService.ChatInputBarConfiguration.IsFocused or false


Prefer using service.TextChatService:FindFirstChildOfClass("ChatInputBarConfiguration") to get the ChatInputBarConfiguration instance. ChatInputBarConfiguration is not a property of TextChatService, but rather a child instance under TextChatService.

Right, it can be renamed

Expertcoderz · 2025-11-12T03:56:57Z

MainModule/Client/UI/Aero/PlayerList.rbxmx

-		local textbox = service.UserInputService:GetFocusedTextBox()
-		if not (textbox) and InputObject.UserInputType==Enum.UserInputType.Keyboard and InputObject.KeyCode == Enum.KeyCode.Tab then
+	service.UserInputService.InputBegan:Connect(InputObject, gameProcessedEvent)
+		local textbox = service.UserInputService:GetFocusedTextBox() ~= nil


Same thing as the first comment: rename textbox to textboxFocused.

Expertcoderz · 2025-11-12T03:58:59Z

MainModule/Client/UI/Aero/PlayerList.rbxmx

-		if not (textbox) and InputObject.UserInputType==Enum.UserInputType.Keyboard and InputObject.KeyCode == Enum.KeyCode.Tab then
+	service.UserInputService.InputBegan:Connect(InputObject, gameProcessedEvent)
+		local textbox = service.UserInputService:GetFocusedTextBox() ~= nil
+		local chatFocused = service.TextChatService and service.TextChatService.ChatInputBarConfiguration and service.TextChatService.ChatInputBarConfiguration.IsFocused or false


Same thing as the second comment: use :FindFirstChildOfClass() to get the ChatInputBarConfiguration.

Expertcoderz · 2025-11-12T04:02:30Z

MainModule/Client/UI/Default/Console.rbxmx

 	gTable.BindEvent(service.UserInputService.InputBegan, function(inputObject: InputObject, gameProcessedEvent)
-		local textbox = service.UserInputService:GetFocusedTextBox()
-		if not textbox and not gameProcessedEvent and rawequal(inputObject.UserInputType, Enum.UserInputType.Keyboard) and inputObject.KeyCode.Name == (Variables.CustomConsoleKey or consoleKey) then
+		local textbox = service.UserInputService:GetFocusedTextBox() ~= nil


Please consider applying the same changes suggested in the first and second comments, for the rest of the files.
(Yeah, it's kinda sad how adonis has lots and lots of duplicated code across the UI themes. We should fix this someday.)

(Fix someday = until roblox inevitably breaks it or someone comes up with a genius solution at 1AM)

GalacticInspired · 2025-12-18T13:18:10Z

Please submit this PR again once requested changes have been made.

totallytavi added 6 commits September 19, 2025 16:47

fix console key not respecting chat (rounded theme)

7e99b4a

fix console key not respecting chat (winxp theme)

cd6ee8b

fix console key not respecting chat (steampunk theme)

c5b277d

fix console key not respecting chat (unity theme)

9f37e80

fix console key not respecting chat (aero theme)

52936cd

fix console key not respecting chat (default theme)

da66f6d

totallytavi changed the title ~~Ensure console respects chat~~ Ensure console keybind respects chat Sep 19, 2025

Merge branch 'Epix-Incorporated:master' into master

ddec041

This comment was marked as spam.

Sign in to view

totallytavi added 2 commits October 22, 2025 13:18

fix: ensure InputBegan respects GPE and chat

4afdda4

* Ensure textbox is a boolean in checks * Add fallback of false for all checks * Add gameProcessedEvent to checks

fix: separate chatFocused checks for InputBegan

6281146

* Add logic to check for all instances needed * Add fallback in the event none exist * Remove unneeded "or false" from textbox check

Dimenpsyonal added the 🎏 miscellaneous Miscellaneous content label Nov 3, 2025

totallytavi requested a review from Dimenpsyonal November 10, 2025 18:02

Expertcoderz requested changes Nov 12, 2025

View reviewed changes

Epix-Incorporated deleted a comment from coderabbitai bot Dec 18, 2025

GalacticInspired marked this pull request as draft December 18, 2025 13:17

Merge branch 'Epix-Incorporated:master' into master

3bbc4d3

Uh oh!

Conversation

totallytavi commented Sep 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Minimum reproducible example

Summary by CodeRabbit

Uh oh!

ari-party commented Sep 22, 2025

Uh oh!

totallytavi commented Sep 22, 2025

Uh oh!

GalacticInspired commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

totallytavi commented Oct 7, 2025

Uh oh!

GalacticInspired commented Oct 13, 2025

Uh oh!

totallytavi commented Oct 15, 2025

Uh oh!

totallytavi commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

totallytavi commented Oct 22, 2025

Uh oh!

This comment was marked as spam.

Uh oh!

Expertcoderz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GalacticInspired commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

totallytavi commented Sep 19, 2025 •

edited by coderabbitai bot

Loading

GalacticInspired commented Oct 4, 2025 •

edited

Loading

totallytavi commented Oct 22, 2025 •

edited

Loading

Expertcoderz left a comment •

edited

Loading