Conversation
| overrideConfigFile: './.eslintrc.js' | ||
| Buffer: [ 'buffer', 'Buffer' ], | ||
| }), | ||
| // new ESLintPlugin({ |
There was a problem hiding this comment.
Try not to leave commented out code in the final code. If needed, uncomment it, if not then remove it.
| port: 8080, | ||
| hot: true, | ||
| historyApiFallback: { | ||
| // If the URL contains a product endpoint and we server a static file |
There was a problem hiding this comment.
This comment might be informative in the future. You could keep it.
| width="400" | ||
| > | ||
| <template v-slot:activator="{ on }"> | ||
| <template #activator="{ props }"> |
There was a problem hiding this comment.
Is it a best practice to replace v-slot with a hash mark?
| this.resetDateTimes(); | ||
| } | ||
| }, | ||
|
|
There was a problem hiding this comment.
Deleting every single empty line will not make the code better but makes readability worse. Don't remove all of it but decide with the question: "Will it make the code readable?".
|
|
||
| class CodeCheckerService extends BaseService { | ||
| constructor() { | ||
| super("CodeCheckerService", ServiceClient,"v6.61", true); |
There was a problem hiding this comment.
Didn't you remove the appended 'v' from an other place too? If I'm right, by removing this too, it will get rid of the 'v' in the whole version number.
| @@ -181,88 +183,96 @@ export default { | |||
| mixins: [ VersionMixin ], | |||
|
|
|||
| data() { | |||
There was a problem hiding this comment.
What happened to the identation?
2 participants
Migrated runs page