fix: correct the error of hardcoded prisma/kafka schema#2083
Merged
DavidsonGomes merged 1 commit intoEvolutionAPI:developfrom Oct 15, 2025
Merged
fix: correct the error of hardcoded prisma/kafka schema#2083DavidsonGomes merged 1 commit intoEvolutionAPI:developfrom
DavidsonGomes merged 1 commit intoEvolutionAPI:developfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the PostgreSQL migration script for Kafka integration by removing explicit “public” schema qualifiers and relying on unqualified table names for CREATE TABLE, index, and foreign key definitions. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Add a down migration or in-place rename logic so existing deployments of the "public.Kafka" table aren’t orphaned when this schema correction runs.
- Consider making the schema name configurable via environment or Prisma settings instead of hardcoding to support non-public schemas.
- Ensure all other migrations and model definitions have had their schema qualifications updated consistently to avoid mismatches.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add a down migration or in-place rename logic so existing deployments of the "public.Kafka" table aren’t orphaned when this schema correction runs.
- Consider making the schema name configurable via environment or Prisma settings instead of hardcoding to support non-public schemas.
- Ensure all other migrations and model definitions have had their schema qualifications updated consistently to avoid mismatches.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
🔗 Related Issue
Closes #(2069)
🧪 Type of Change
🧪 Testing
📸 Screenshots (if applicable)
✅ Checklist
📝 Additional Notes
Summary by Sourcery
Bug Fixes: