Convert LIDs to PN by sending a call rejection message

[KokeroO]

📋 Description

🔗 Related Issue

Closes #(issue_number)

🧪 Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📚 Documentation update
• 🔧 Refactoring (no functional changes)
• ⚡ Performance improvement
• 🧹 Code cleanup
• 🔒 Security fix

🧪 Testing

• Manual testing completed
• Functionality verified in development environment
• No breaking changes introduced
• Tested with different connection types (if applicable)

📸 Screenshots (if applicable)

✅ Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have manually tested my changes thoroughly
• I have verified the changes work with different scenarios
• Any dependent changes have been merged and published

📝 Additional Notes

Corrige o número utilizando getLIDForPN() para resposta ao rejeitar uma chamada. Principal mudança seria no recebimento no webhook e na conversa correta no Chatwoot.

Summary by Sourcery

Fix Failed Call Handling for LID-Originated WhatsApp Calls and Chat ID Parsing in Chatwoot

Bug Fixes:

• Map WhatsApp LIDs to phone numbers before sending call rejection messages
• Strip extra suffixes from remote JIDs when determining chat IDs in Chatwoot

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR ensures that call rejection messages are sent to the correct phone number by converting LIDs to PNs and refines the Chatwoot integration to accurately parse chat IDs by stripping trailing suffixes.

Sequence diagram for call rejection message with LID to PN conversion

sequenceDiagram
    participant BaileysStartupService
    participant SignalRepository
    participant WhatsAppClient
    participant ChatwootService
    BaileysStartupService->>WhatsAppClient: Receive call with 'offer' status
    alt call.from ends with '@lid'
        BaileysStartupService->>SignalRepository: getPNForLID(call.from)
        SignalRepository-->>BaileysStartupService: Return PN
        BaileysStartupService->>WhatsAppClient: sendMessage(PN, msgCall)
    else call.from is PN
        BaileysStartupService->>WhatsAppClient: sendMessage(call.from, msgCall)
    end
    WhatsAppClient->>ChatwootService: Emit 'messages.upsert' event

Loading

Class diagram for BaileysStartupService and SignalRepository changes

classDiagram
    class BaileysStartupService {
        +client: WhatsAppClient
        +rejectCall(call)
    }
    class WhatsAppClient {
        +signalRepository: SignalRepository
        +sendMessage(to, message)
        +ev: EventEmitter
    }
    class SignalRepository {
        +lidMapping: LIDMapping
    }
    class LIDMapping {
        +getPNForLID(lid: string): string
    }
    BaileysStartupService --> WhatsAppClient
    WhatsAppClient --> SignalRepository
    SignalRepository --> LIDMapping

Loading

File-Level Changes

Change	Details	Files
Convert LID identifiers to PNs before sending call rejection	Detect when call.from ends with '@lid' Invoke getPNForLID to translate LID into a PN prior to messaging	src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts
Strip extraneous suffixes from remoteJid to derive correct chatId	For non-group chats, split remoteJid at '@' and then at ':' to remove trailing parts	src/api/integrations/chatbot/chatwoot/services/chatwoot.service.ts

Possibly linked issues

• Problemas ao enviar mídias para o Celular usando o Typebot ou Postman #123: PR converts LIDs to phone numbers and adjusts chat ID parsing, resolving the 'Unknown argument lid' error.
• Docker folder is deleted #1: PR fixes @lid messages not received by converting LIDs to PNs and correctly parsing chat IDs in Chatwoot.
• #issue-123: The PR converts LIDs to PNs during call rejection and refines remoteJid extraction, directly resolving the issue of LIDs appearing instead of remoteJids.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider adding a debug log after converting a LID to a PN in whatsapp.baileys.service.ts so you can trace when and how often that mapping occurs.
• The chatId split(':')[0] change in chatwoot.service.ts might still break on more complex JID formats—consider using a dedicated JID parser or regex to reliably extract the user portion.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider adding a debug log after converting a LID to a PN in whatsapp.baileys.service.ts so you can trace when and how often that mapping occurs.
- The chatId split(':')[0] change in chatwoot.service.ts might still break on more complex JID formats—consider using a dedicated JID parser or regex to reliably extract the user portion.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}