Fix: Sending response to all pending async_responses if channel has gone away#95
Open
Fix: Sending response to all pending async_responses if channel has gone away#95
Conversation
italorossi
requested changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Edge case when we are awaiting for an
async_reponseson some API or Command, and theCHANNEL_hANGUPevent comes before all pending responses events, such asCHANNEL_EXECUTE_COMPLETE, the outbound Session will wait forever.Details:
Setting response to all pending async_reponse to
-ERR Socket has gone awayto unblock all pending requests on the default hangup handlerPS: Maybe if we register
CHANNEL_HANGUP_COMPLETEinstead ofCHANNEL_HANGUPto be the default hangup handler, we can also bypass this (not sure)