Conversation
ChALkeR
force-pushed
the
chalker/perf/2
branch
from
8aaf6a4 to
ff2eee0
Compare
ChALkeR
commented
Dec 1, 2025
fallback/base64.js
Outdated
|
|
||
| if (nativeEncoder) { | ||
| if (!helpers.fromMap16) { | ||
| helpers.fromMap16 = new Uint16Array(_zz + 1) // Warning: 64 KiB |
Collaborator
Author
There was a problem hiding this comment.
perhaps a holey array could help here instead
it reduces perf benefit but hermes still wins
need to check mem usage
ChALkeR
force-pushed
the
chalker/perf/2
branch
from
ff2eee0 to
bb9a3c1
Compare
ChALkeR
force-pushed
the
master
branch
16 times, most recently
from
a5c78cc to
ef95acb
Compare
ChALkeR
force-pushed
the
master
branch
7 times, most recently
from
67fc5e1 to
2d1cb34
Compare
ChALkeR
force-pushed
the
master
branch
14 times, most recently
from
6035cd8 to
2c93e67
Compare
ChALkeR
force-pushed
the
master
branch
4 times, most recently
from
58a0c1f to
a1f6d7a
Compare
ChALkeR
force-pushed
the
main
branch
2 times, most recently
from
24cb480 to
c82c99f
Compare
ChALkeR
force-pushed
the
main
branch
4 times, most recently
from
56ca4f6 to
d30e288
Compare
ChALkeR
force-pushed
the
main
branch
4 times, most recently
from
b2e260a to
9e30190
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering this
On the downside, this consumes 64 KiB cache (and +64 KiB for base64url)
On the upside, this improves fallback perf from
5807to9576on Hermes, beatingatob()codepath used now (with7308)Also significantly improves browser fallbacks (but old browsers are not important)
Likely I'll abandon this due to 128 KiB cache being too large