fix(web): handle text input metrics correctly on history undo events#434
Draft
hannojg wants to merge 9 commits intoExpensify:mainfrom
Draft
fix(web): handle text input metrics correctly on history undo events#434hannojg wants to merge 9 commits intoExpensify:mainfrom
hannojg wants to merge 9 commits intoExpensify:mainfrom
Conversation
Contributor
Author
|
@Skalakid may I ask you (or someone from your team) to review? thank you so much |
61 tasks
Skalakid
previously approved these changes
Jul 17, 2024
Contributor
Skalakid
left a comment
Skalakid
left a comment
There was a problem hiding this comment.
Overall looks good to me, left 2 small comments
Skalakid
previously approved these changes
Jul 17, 2024
Contributor
|
@hannojg some check are failing, please fix TS and ESlint errors |
Contributor
Author
|
Do you know if there is any bump PR in expensify already? |
Contributor
Skalakid
previously approved these changes
Jul 17, 2024
Contributor
|
@hannojg Somehow not all of your commits are signed, can you rebase and sign them, please? |
Signed-off-by: Hanno J. Gödecke <die.drei99@yahoo.de>
Signed-off-by: Hanno J. Gödecke <die.drei99@yahoo.de>
Signed-off-by: Hanno J. Gödecke <die.drei99@yahoo.de>
Signed-off-by: Hanno J. Gödecke <die.drei99@yahoo.de>
hannojg
force-pushed
the
fix/web-onchange-history-evenst
branch
from
29ca4c7 to
894790d
Compare
…n into fix/web-onchange-history-evenst
hannojg
dismissed
Skalakid’s stale review
The merge-base changed after approval.
Contributor
Author
|
Lets wait with merging one second - testing the changes in my expensify PR right now, there might be one problem left! |
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
In this PR I added ranges to the onChange event:
onChangeevent #412However there was a bug where when undoing using
ctrl + zthestartandbeforevalues where incorrect.Additionally in this PR I did a cleanup and moved the code that calculates the replacement metrics to a function in the parseUtils.
Note: this PR contains changes from:
So we should merge that one first, or close it and instead just merge this PR.
Related Issues
Expensify/App#37896
Manual Tests
Linked PRs
Expensify/App#44285