Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
CLABotify
added a commit
to Expensify/CLA
that referenced
this pull request
Feb 18, 2025
Contributor
Author
|
hmm it seems like npm still has the old URLs for this repo - https://www.npmjs.com/package/react-native-qrcode-svg |
Kicu
reviewed
Feb 19, 2025
Contributor
Kicu
left a comment
Kicu
left a comment
There was a problem hiding this comment.
You probably also should change it in lines 52 and 50.
Yeah this link on npm never got changed after the transfer of ownership. Perhaps if we publish a version with updated package.json then npm info will get updated? 🤔
Contributor
Author
|
Updated! |
roryabraham
approved these changes
Feb 21, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Coming from this thread, we added provenance to the
npm publishworkflow, so we need to make sure the repo URL matches what npm expectsWhat this fixes
https://expensify.slack.com/archives/C06BDSWLDPB/p1739793644035839