Skip to content

Conversation

@haeussma
Copy link
Member

@haeussma haeussma commented Jan 27, 2026

…himadzuReader with detailed logging for file processing and value mapping.


Note

Adjusts file processing order and adds targeted debug logs.

  • ShimadzuReader now iterates over self.file_paths without additional sorting, relying on upstream ordering to align files with self.values
  • Adds JSON debug logging to a local file in read() and _get_file_paths() capturing file lists and file-to-value mapping
  • Bumps version to 0.10.9 in pyproject.toml and __init__.py

Written by Cursor Bugbot for commit cd2367f. This will update automatically on new commits. Configure here.

…himadzuReader with detailed logging for file processing and value mapping.
@haeussma haeussma merged commit 2434361 into main Jan 27, 2026
2 of 14 checks passed
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

}
)
+ "\n"
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug logging writes to hardcoded local path

High Severity

Debug logging code was accidentally committed that writes to a hardcoded developer-specific path /Users/max/code/aldol_addition/.cursor/debug.log. This will cause a FileNotFoundError crash when read() or _get_file_paths() is called on any machine that doesn't have this exact directory structure, making ShimadzuReader completely unusable in production.

Additional Locations (2)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant