Skip to content

Use filesystem path rather than strings for paths to VTKHDF writer #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorgensd merged 2 commits into from
Feb 4, 2026
Merged

Use filesystem path rather than strings for paths to VTKHDF writer #4067

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c96155
Use filesystem path
jorgensd Feb 4, 2026
0fcb86d
Merge branch 'main' into dokken/vtkhdf-stdfilename
jorgensd Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cpp/dolfinx/io/VTKHDF.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ namespace dolfinx::io::VTKHDF
/// @param filename Name of file to write to.
/// @param mesh Mesh to write to file.
template <std::floating_point U>
void write_mesh(std::string filename, const mesh::Mesh<U>& mesh)
void write_mesh(const std::filesystem::path& filename,
const mesh::Mesh<U>& mesh)
{
hid_t h5file = hdf5::open_file(mesh.comm(), filename, "w", true);

Expand Down Expand Up @@ -171,7 +172,8 @@ void write_mesh(std::string filename, const mesh::Mesh<U>& mesh)
/// @note Limited support for floating point types at present (no
/// complex number support).
template <std::floating_point U>
void write_data(std::string point_or_cell, std::string filename,
void write_data(std::string point_or_cell,
const std::filesystem::path& filename,
const mesh::Mesh<U>& mesh, const std::vector<U>& data,
double time)
{
Expand Down Expand Up @@ -310,7 +312,7 @@ void write_data(std::string point_or_cell, std::string filename,
/// facet can be connected to.
/// @return The mesh read from file.
template <std::floating_point U>
mesh::Mesh<U> read_mesh(MPI_Comm comm, std::string filename,
mesh::Mesh<U> read_mesh(MPI_Comm comm, const std::filesystem::path& filename,
std::size_t gdim = 3,
std::optional<std::int32_t> max_facet_to_cell_links = 2)
{
Expand Down
Loading