Open
Conversation
flibitijibibo
requested changes
Dec 8, 2024
Member
flibitijibibo
left a comment
flibitijibibo
left a comment
There was a problem hiding this comment.
One note applied to various places in the fix
| // Open the device! | ||
| INTERNAL_devices[which] = SDL.SDL_OpenGamepad(dev); | ||
| string error = SDL.SDL_GetError(); | ||
| if (!string.IsNullOrEmpty(error)) { |
Member
There was a problem hiding this comment.
Similar to the other checks we should use tue return value of the function instead of the error buffer
Member
|
Fast-tracked the fixes, so it's just the error logging that's left: 6415dfd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.