Add Partially Deobfuscated Classes panel#482
Draft
NebelNidas wants to merge 4 commits intoFabricMC:masterfrom
Draft
Add Partially Deobfuscated Classes panel#482NebelNidas wants to merge 4 commits intoFabricMC:masterfrom
Partially Deobfuscated Classes panel#482NebelNidas wants to merge 4 commits intoFabricMC:masterfrom
Conversation
Member
Author
|
Works fine with my testing. The only issues left are ones that have to be fixed by other PRs:
|
9 tasks
This was referenced Feb 15, 2023
Member
Author
|
This PR has some serious performance problems when importing larger JARs, and to be fair, the UI isn't great either with how clamped up everything gets, I think this needs a larger overhaul later down the line when my new IR stuff is finished and Matcher support gets added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up the discussion on Discord from May, I've split up the deobfuscation panel into two: A
Partially Deobfuscated Classespanel and aFully Deobfuscated Classesone.While being at it, here are some related changes I made:
moveClassTreefunction, fixed a bug introduced over two years ago via QOL fixes - Volume 2 #239 which rendered the lastelsecondition unreachableClassPanelabstract class which the three other class panels inherit from. Also moved them into a new subpackage, although I wasn't quite sure how to name it, so please tell me if you have a better nameGuiController.java, it now uses the methods fromGui.javaDeobfPanelPopupMenutoClassPanelContextMenu, as it can be used on all three panels nowIt may not be the cleanest of implementations, but hey, it works 😄