Remove an outer class null check in TranslationClassVisitor#538
Open
sumguytho wants to merge 1 commit intoFabricMC:masterfrom
Open
Remove an outer class null check in TranslationClassVisitor#538sumguytho wants to merge 1 commit intoFabricMC:masterfrom
sumguytho wants to merge 1 commit intoFabricMC:masterfrom
Conversation
ix0rai
pushed a commit
to QuiltMC/enigma
that referenced
this pull request
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to JVMS for java SE 20 there some cases when an inner class shouldn't have an outer one. This check wasn't there until 00fcd05 and the reason for this check isn't provided in code.